Bug 185525 - Don't allocate value profiles when the JIT is disabled
Summary: Don't allocate value profiles when the JIT is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 185524
  Show dependency treegraph
 
Reported: 2018-05-10 12:05 PDT by Saam Barati
Modified: 2018-05-11 00:58 PDT (History)
18 users (show)

See Also:


Attachments
patch (8.41 KB, patch)
2018-05-10 16:26 PDT, Saam Barati
msaboff: review+
Details | Formatted Diff | Diff
patch for landing (8.45 KB, patch)
2018-05-10 20:30 PDT, Saam Barati
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch for landing (8.45 KB, patch)
2018-05-10 20:42 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-05-10 12:05:15 PDT
...
Comment 1 Saam Barati 2018-05-10 16:26:56 PDT
Created attachment 340144 [details]
patch
Comment 2 EWS Watchlist 2018-05-10 16:28:27 PDT
Attachment 340144 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/Heap.cpp:1461:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Saboff 2018-05-10 18:38:41 PDT
Comment on attachment 340144 [details]
patch

r=me
Comment 4 Saam Barati 2018-05-10 20:30:44 PDT
Created attachment 340162 [details]
patch for landing

Thanks for the review.
Comment 5 EWS Watchlist 2018-05-10 20:31:52 PDT
Attachment 340162 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/Heap.cpp:1461:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2018-05-10 20:36:54 PDT
Comment on attachment 340162 [details]
patch for landing

Rejecting attachment 340162 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 340162, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/7646602
Comment 7 Saam Barati 2018-05-10 20:42:54 PDT
Created attachment 340164 [details]
patch for landing
Comment 8 WebKit Commit Bot 2018-05-11 00:57:26 PDT
Comment on attachment 340164 [details]
patch for landing

Clearing flags on attachment: 340164

Committed r231695: <https://trac.webkit.org/changeset/231695>
Comment 9 WebKit Commit Bot 2018-05-11 00:57:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-05-11 00:58:19 PDT
<rdar://problem/40156489>