RESOLVED FIXED 185511
[GTK] Implement ImageBuffer::toBGRAData 
https://bugs.webkit.org/show_bug.cgi?id=185511
Summary [GTK] Implement ImageBuffer::toBGRAData
Thibault Saunier
Reported 2018-05-10 05:45:34 PDT
.
Attachments
[GTK] Implement ImageBuffer::toBGRAData (3.18 KB, patch)
2018-05-10 05:49 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Minor typo fix since previous version. (3.18 KB, patch)
2018-05-10 05:51 PDT, Thibault Saunier 		mcatanzaro: review+
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
(In reply to Michael Catanzaro from comment #3) (4.15 KB, patch)
2018-05-10 07:06 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-05-10 05:49:58 PDT
Created attachment 340086 [details] [GTK] Implement ImageBuffer::toBGRAData This was never implemented but will is required for the MediaStream API tests.
Thibault Saunier
Comment 2 2018-05-10 05:51:39 PDT
Created attachment 340087 [details] Minor typo fix since previous version.
Michael Catanzaro
Comment 3 2018-05-10 06:44:52 PDT
Comment on attachment 340087 [details] Minor typo fix since previous version. View in context: https://bugs.webkit.org/attachment.cgi?id=340087&action=review > Source/WebCore/ChangeLog:8 > + [GTK] Implement ImageBuffer::toBGRAData The commit title doesn't belong here, you already have it properly up at the top. > Source/WebCore/platform/graphics/ImageBuffer.cpp:105 > +#if USE(CG) && !PLATFORM(GTK) Move the CG implementation to ImageBufferCG.cpp, then this condition can become #if !USE(CG) && !PLATFORM(GTK).
Thibault Saunier
Comment 4 2018-05-10 07:06:35 PDT
Created attachment 340088 [details] (In reply to Michael Catanzaro from comment #3) > Comment on attachment 340087 [details] > Minor typo fix since previous version. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340087&action=review > > > Source/WebCore/ChangeLog:8 > > + [GTK] Implement ImageBuffer::toBGRAData > > The commit title doesn't belong here, you already have it properly up at the > top. Not sure how that happened, I just used prepareChangeLog, anyway Fixed. > > Source/WebCore/platform/graphics/ImageBuffer.cpp:105 > > +#if USE(CG) && !PLATFORM(GTK) > > Move the CG implementation to ImageBufferCG.cpp, then this condition can > become #if !USE(CG) && !PLATFORM(GTK). Done.
WebKit Commit Bot
Comment 5 2018-05-10 07:50:47 PDT
Comment on attachment 340088 [details] (In reply to Michael Catanzaro from comment #3) Clearing flags on attachment: 340088 Committed r231638: <https://trac.webkit.org/changeset/231638>
WebKit Commit Bot
Comment 6 2018-05-10 07:50:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-05-10 07:51:41 PDT
<rdar://problem/40127886>
Note You need to log in before you can comment on or make changes to this bug.