Bug 185510 - [GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase
Summary: [GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-10 05:41 PDT by Thibault Saunier
Modified: 2018-05-14 09:19 PDT (History)
4 users (show)

See Also:

Attachments
[GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase (4.40 KB, patch)
2018-05-10 05:44 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
[GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase (4.34 KB, patch)
2018-05-14 07:29 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-05-10 05:41:32 PDT 
.
Comment 1 Thibault Saunier 2018-05-10 05:44:22 PDT 
Created attachment 340085 [details]
[GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase

ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:629:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:684:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:807:  More than one command on the same line  [whitespace/newline] [4]
Comment 2 Philippe Normand 2018-05-14 07:13:29 PDT 
Comment on attachment 340085 [details]
[GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase

View in context: https://bugs.webkit.org/attachment.cgi?id=340085&action=review

> Source/WebCore/ChangeLog:8
> +        [GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase

Please remove this line
Comment 3 Thibault Saunier 2018-05-14 07:29:02 PDT 
Created attachment 340314 [details]
[GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase

>> Source/WebCore/ChangeLog:8
>> +        [GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase
>
> Please remove this line

Done.
Comment 4 WebKit Commit Bot 2018-05-14 09:18:42 PDT 
Comment on attachment 340314 [details]
[GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase

Clearing flags on attachment: 340314

Committed r231759: <https://trac.webkit.org/changeset/231759>
Comment 5 WebKit Commit Bot 2018-05-14 09:18:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-05-14 09:19:16 PDT 
<rdar://problem/40219722>