Bug 185505 - REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
Summary: REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in Web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-09 23:32 PDT by Fujii Hironori
Modified: 2018-05-10 13:51 PDT (History)
2 users (show)

See Also:


Attachments
WIP patch (1.26 KB, patch)
2018-05-09 23:37 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (2.35 KB, patch)
2018-05-10 00:08 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-05-09 23:32:32 PDT
REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged

Windows port crashes soon since Bug 184996.

> WebKit.dll!WebView::notifyPreferencesChanged(IWebNotification * notification) Line 5201	C++
> WebKit.dll!WebView::onNotify(IWebNotification * notification) Line 5072	C++
> WebKit.dll!WebNotificationCenter::postNotificationInternal(IWebNotification * notification, wchar_t * notificationName, IUnknown * anObject) Line 131	C++
> WebKit.dll!WebNotificationCenter::postNotificationName(wchar_t * notificationName, IUnknown * anObject, IPropertyBag * userInfo) Line 181	C++
> WebKit.dll!WebPreferences::postPreferencesChangesNotification() Line 148	C++
> WebKit.dll!WebView::initWithFrame(tagRECT frame, wchar_t * frameName, wchar_t * groupName) Line 3164	C++
> MiniBrowserLib.dll!MiniBrowser::prepareViews(HWND__ * mainWnd, const tagRECT & clientRect, HWND__ * & viewHwnd) Line 183	C++
> MiniBrowserLib.dll!MiniBrowser::MiniBrowser(HWND__ * mainWnd, HWND__ * urlBarWnd, bool useLayeredWebView, bool pageLoadTesting) Line 140	C++
> [External Code]	
> MiniBrowserLib.dll!BrowserWindow::{ctor}::__l2::<lambda>(HWND__ * mainWnd, HWND__ * urlBarWnd, bool useLayeredWebView, bool pageLoadTesting) Line 111	C++
> MiniBrowserLib.dll!std::unique_ptr<ContentWindow,std::default_delete<ContentWindow> > <lambda>(HWND__ *, HWND__ *, bool, bool)::<lambda_invoker_cdecl>(HWND__ * mainWnd, HWND__ * urlBarWnd, bool useLayeredWebView, bool pageLoadTesting) Line 112	C++
> MiniBrowserLib.dll!BrowserWindow::BrowserWindow(int nCmdShow, bool usesLayeredWebView, bool pageLoadTesting, _bstr_t requestedURL, bool useWK2) Line 120	C++
> MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 75	C++
> MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 109	C++
> MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 251	C++
> [External Code]
Comment 1 Fujii Hironori 2018-05-09 23:37:14 PDT
Created attachment 340073 [details]
WIP patch
Comment 2 Fujii Hironori 2018-05-10 00:08:16 PDT
Created attachment 340076 [details]
Patch
Comment 3 Fujii Hironori 2018-05-10 00:16:44 PDT
Committed r231635: <https://trac.webkit.org/changeset/231635>
Comment 4 Radar WebKit Bug Importer 2018-05-10 00:17:20 PDT
<rdar://problem/40120805>
Comment 5 Chris Dumez 2018-05-10 13:51:00 PDT
Comment on attachment 340076 [details]
Patch

Thanks for fixing!