Right now, Markup.dump doesn't log the selection anchor or the selection focus when their container node is the root node passed to Markup.dump. This is inconvenient since it's common for the caret / selection's end points to be anchored at the root editable element, which is typically the root node passed to Markup.dump.
Created attachment 340052 [details] Improves Markup
Comment on attachment 340052 [details] Improves Markup Attachment 340052 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7630893 New failing tests: editing/deleting/delete-emoji-9.html editing/deleting/delete-emoji-8.html editing/deleting/delete-emoji-6.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-4.html editing/deleting/delete-emoji-2.html editing/deleting/delete-emoji-3.html editing/deleting/delete-emoji-5.html editing/deleting/delete-emoji-7.html
Created attachment 340055 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 340052 [details] Improves Markup Attachment 340052 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7630945 New failing tests: editing/deleting/delete-emoji-9.html editing/deleting/delete-emoji-8.html editing/deleting/delete-emoji-6.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-4.html editing/deleting/delete-emoji-2.html fast/events/5056619.html editing/deleting/delete-emoji-3.html editing/deleting/delete-emoji-5.html editing/deleting/delete-emoji-7.html
Created attachment 340056 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Ugh... looks like macOS Sierra has its own expectations for these layout tests :(
Comment on attachment 340052 [details] Improves Markup Attachment 340052 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7631042 New failing tests: editing/deleting/delete-emoji-9.html editing/deleting/delete-emoji-8.html editing/deleting/delete-emoji-6.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji.html editing/deleting/delete-emoji-4.html editing/deleting/delete-emoji-2.html editing/deleting/delete-emoji-3.html editing/deleting/delete-emoji-5.html editing/deleting/delete-emoji-7.html
Created attachment 340059 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 340052 [details] Improves Markup Attachment 340052 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7631316 New failing tests: editing/deleting/delete-emoji-9.html editing/deleting/delete-emoji-8.html editing/deleting/delete-emoji-6.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-4.html editing/deleting/delete-emoji-2.html fast/events/5056619.html editing/deleting/delete-emoji-3.html editing/deleting/delete-emoji-5.html editing/deleting/delete-emoji-7.html
Created attachment 340063 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 340067 [details] Improves Markup.dump
Thanks for the review!
Committed r231630: <https://trac.webkit.org/changeset/231630>
<rdar://problem/40120165>
Nice! But looks like Windows results will need to be updated too?
(In reply to Alexey Proskuryakov from comment #15) > Nice! But looks like Windows results will need to be updated too? Hm... I thought there were no Windows specific results. Do you have any links to Windows bots where you're seeing failures?