Bug 185492 - Support --verbose in run-javascriptcore-tests
Summary: Support --verbose in run-javascriptcore-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-09 14:45 PDT by Stephan Szabo
Modified: 2018-05-10 12:12 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.21 KB, patch)
2018-05-09 14:48 PDT, Stephan Szabo
dbates: review+
Details | Formatted Diff | Diff
Updated patch with review comments (2.05 KB, patch)
2018-05-10 10:18 PDT, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2018-05-09 14:45:56 PDT
Support --verbose in run-javascriptcore-tests
Comment 1 Stephan Szabo 2018-05-09 14:48:00 PDT
Created attachment 340033 [details]
Patch
Comment 2 Daniel Bates 2018-05-10 00:20:53 PDT
Comment on attachment 340033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340033&action=review

> Tools/Scripts/run-javascriptcore-tests:235
> +  --verbose:                    Print more things while running. (can be specified multiple times)

Looking at the existing usage descriptions in this file and in test-webkitpy we seem to incorporate the parentheses into the first sentence instead of in another sentence, taking inspiration from test-webkitpy I would write this as:

Verbose output (specify more than once to increase verbosity).

> Tools/Scripts/run-javascriptcore-tests:524
> +        push(@jscStressDriverCmd, ("--verbose") x $verbose)

Missing ‘;’ at the end of this line. Not sure how this ran without an error/warning. We prefer to write single body if blocks using one line:

push(@jscStressDriverCmd, ("--verbose") x $verbose) if ($verbose > 0);
Comment 3 Stephan Szabo 2018-05-10 10:18:46 PDT
Created attachment 340098 [details]
Updated patch with review comments

Here's an updated version with changed help text and converting to ... if (...) form.
Comment 4 WebKit Commit Bot 2018-05-10 12:11:52 PDT
Comment on attachment 340098 [details]
Updated patch with review comments

Clearing flags on attachment: 340098

Committed r231652: <https://trac.webkit.org/changeset/231652>
Comment 5 WebKit Commit Bot 2018-05-10 12:11:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-05-10 12:12:22 PDT
<rdar://problem/40136619>