Support --verbose in run-javascriptcore-tests
Created attachment 340033 [details] Patch
Comment on attachment 340033 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340033&action=review > Tools/Scripts/run-javascriptcore-tests:235 > + --verbose: Print more things while running. (can be specified multiple times) Looking at the existing usage descriptions in this file and in test-webkitpy we seem to incorporate the parentheses into the first sentence instead of in another sentence, taking inspiration from test-webkitpy I would write this as: Verbose output (specify more than once to increase verbosity). > Tools/Scripts/run-javascriptcore-tests:524 > + push(@jscStressDriverCmd, ("--verbose") x $verbose) Missing ‘;’ at the end of this line. Not sure how this ran without an error/warning. We prefer to write single body if blocks using one line: push(@jscStressDriverCmd, ("--verbose") x $verbose) if ($verbose > 0);
Created attachment 340098 [details] Updated patch with review comments Here's an updated version with changed help text and converting to ... if (...) form.
Comment on attachment 340098 [details] Updated patch with review comments Clearing flags on attachment: 340098 Committed r231652: <https://trac.webkit.org/changeset/231652>
All reviewed patches have been landed. Closing bug.
<rdar://problem/40136619>