_syncNetworkProcessCookies is completely async after r231536, so we need to update the test using this API.
<rdar://problem/37214391>
Created attachment 340015 [details] Patch
Comment on attachment 340015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340015&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:150 > + TestWebKitAPI::Util::spinRunLoop(1); I am worried this could still be flaky. How do we know that spinning the runloop 10 times will be sufficient for us: 1. Sending the async IPC to the network process 2. The network process receiving the IPC and asking CFNetwork do sync the cookies 3. Cookies are done sync'ing by the CFNetwork.
Created attachment 340028 [details] Patch
(In reply to Chris Dumez from comment #3) > Comment on attachment 340015 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340015&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:150 > > + TestWebKitAPI::Util::spinRunLoop(1); > > I am worried this could still be flaky. How do we know that spinning the > runloop 10 times will be sufficient for us: > 1. Sending the async IPC to the network process > 2. The network process receiving the IPC and asking CFNetwork do sync the > cookies > 3. Cookies are done sync'ing by the CFNetwork. We don't know. I've changed it to use sleep since second seems to be a better unit for estimation.
Comment on attachment 340028 [details] Patch I would have been more generous than 3 seconds given our slow bots but let's try...
Comment on attachment 340028 [details] Patch Clearing flags on attachment: 340028 Committed r231603: <https://trac.webkit.org/changeset/231603>
All reviewed patches have been landed. Closing bug.
<rdar://problem/40110684>
Comment on attachment 340028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340028&action=review > Tools/ChangeLog:9 > + Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now. "_syncNetworkProcessCookies is async"...
(In reply to Alexey Proskuryakov from comment #10) > Comment on attachment 340028 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340028&action=review > > > Tools/ChangeLog:9 > > + Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now. > > "_syncNetworkProcessCookies is async"... Sync means synchronize here, not synchronous :)