Bug 185486 – Update WebKit.WebsiteDataStoreCustomPaths after r231536

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sihui Liu]

_syncNetworkProcessCookies is completely async after r231536, so we need to update the test using this API.

[Sihui Liu]

<rdar://problem/37214391>

[Sihui Liu]

Created attachment 340015 [details]
Patch

[Chris Dumez]

Comment on attachment 340015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340015&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:150
> +        TestWebKitAPI::Util::spinRunLoop(1);

I am worried this could still be flaky. How do we know that spinning the runloop 10 times will be sufficient for us:
1. Sending the async IPC to the network process
2. The network process receiving the IPC and asking CFNetwork do sync the cookies
3. Cookies are done sync'ing by the CFNetwork.

[Sihui Liu]

Created attachment 340028 [details]
Patch

[Sihui Liu]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 340015 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340015&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:150
> > +        TestWebKitAPI::Util::spinRunLoop(1);
> 
> I am worried this could still be flaky. How do we know that spinning the
> runloop 10 times will be sufficient for us:
> 1. Sending the async IPC to the network process
> 2. The network process receiving the IPC and asking CFNetwork do sync the
> cookies
> 3. Cookies are done sync'ing by the CFNetwork.

We don't know. I've changed it to use sleep since second seems to be a better unit for estimation.

[Chris Dumez]

Comment on attachment 340028 [details]
Patch

I would have been more generous than 3 seconds given our slow bots but let's try...

[WebKit Commit Bot]

Comment on attachment 340028 [details]
Patch

Clearing flags on attachment: 340028

Committed r231603: <https://trac.webkit.org/changeset/231603>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40110684>

[Alexey Proskuryakov]

Comment on attachment 340028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340028&action=review

> Tools/ChangeLog:9
> +        Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.

"_syncNetworkProcessCookies is async"...

[Chris Dumez]

(In reply to Alexey Proskuryakov from comment #10)
> Comment on attachment 340028 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340028&action=review
> 
> > Tools/ChangeLog:9
> > +        Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
> 
> "_syncNetworkProcessCookies is async"...

Sync means synchronize here, not synchronous :)