Bug 185481 - [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
Summary: [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-09 11:25 PDT by Thibault Saunier
Modified: 2018-05-09 12:27 PDT (History)
6 users (show)

See Also:

Attachments
[tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess (1.88 KB, patch)
2018-05-09 11:31 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-05-09 11:25:47 PDT 
.
Comment 1 Thibault Saunier 2018-05-09 11:31:15 PDT 
Created attachment 339993 [details]
[tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
Comment 2 Philippe Normand 2018-05-09 11:48:27 PDT 
Comment on attachment 339993 [details]
[tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess

This is a bit premature? I think we should first bump the jhbuild to 1.14.
Comment 3 Thibault Saunier 2018-05-09 11:53:30 PDT 
(In reply to Philippe Normand from comment #2)
> Comment on attachment 339993 [details]
> [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
> 
> This is a bit premature? I think we should first bump the jhbuild to 1.14.

Well, this is only so that we have a way to run tests against playbin3, this is totally opt-in and it is very unlikely someone set USE_PLAYBIN3 without knowing what he is doing fmpov.
Comment 4 Philippe Normand 2018-05-09 12:09:08 PDT 
Comment on attachment 339993 [details]
[tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess

Oh right, I totally misread the patch :) lgtm!
Comment 5 WebKit Commit Bot 2018-05-09 12:14:08 PDT 
Comment on attachment 339993 [details]
[tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess

Clearing flags on attachment: 339993

Committed r231584: <https://trac.webkit.org/changeset/231584>
Comment 6 WebKit Commit Bot 2018-05-09 12:14:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-09 12:27:47 PDT 
<rdar://problem/40101847>