Bug 185472 - [iOS] Consider the annotation bounds when positioning action sheets near long-pressed PDF links
Summary: [iOS] Consider the annotation bounds when positioning action sheets near long...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-09 08:00 PDT by Andy Estes
Modified: 2018-05-09 12:08 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.98 KB, patch)
2018-05-09 08:11 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-05-09 08:00:20 PDT
[iOS] Consider the annotation bounds when positioning action sheets near long-pressed PDF links
Comment 1 Andy Estes 2018-05-09 08:11:24 PDT
Created attachment 339964 [details]
Patch
Comment 2 Andy Estes 2018-05-09 08:14:28 PDT
rdar://problem/39967092
Comment 3 Daniel Bates 2018-05-09 11:40:03 PDT
Comment on attachment 339964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339964&action=review

r=me

> Source/WebKit/ChangeLog:14
> +        We also no longer need to convert the press location into host view coordinate
> +        space, as PDFKit now does that for us.

Cool.
Comment 4 WebKit Commit Bot 2018-05-09 12:08:36 PDT
Comment on attachment 339964 [details]
Patch

Clearing flags on attachment: 339964

Committed r231583: <https://trac.webkit.org/changeset/231583>
Comment 5 WebKit Commit Bot 2018-05-09 12:08:37 PDT
All reviewed patches have been landed.  Closing bug.