Bug 185452 – InPlaceAbstractState::beginBasicBlock shouldn't copy all m_variables every time

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 340009 [details]
possible patch

[Filip Pizlo]

Created attachment 340048 [details]
patch that might pass tests

[Filip Pizlo]

Created attachment 340050 [details]
rebased patch with changelog

[EWS Watchlist]

Comment on attachment 340050 [details]
rebased patch with changelog

Attachment 340050 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7631247

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 340061 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Filip Pizlo]

Created attachment 340103 [details]
the patch

[Michael Saboff]

Comment on attachment 340103 [details]
the patch

r=me

[Filip Pizlo]

The jsc ews bot saw a failure.  I didn't see any failures running locally.  I'll rerun tests locally anyway, to see if this is real.

[EWS Watchlist]

Comment on attachment 340103 [details]
the patch

Attachment 340103 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7640853

New failing tests:
stress/ftl-put-by-id-setter-exception-interesting-live-state.js.dfg-eager-no-cjit-validate
apiTests

[Filip Pizlo]

(In reply to Build Bot from comment #9)
> Comment on attachment 340103 [details]
> the patch
> 
> Attachment 340103 [details] did not pass jsc-ews (mac):
> Output: http://webkit-queues.webkit.org/results/7640853
> 
> New failing tests:
> stress/ftl-put-by-id-setter-exception-interesting-live-state.js.dfg-eager-no-
> cjit-validate
> apiTests

It's very strange to see this failure.  I don't think it's related.  For example, it didn't happen on the earlier version of this patch, which was identical except for the changelog.  Also, I cannot get this failure on my system.  I tried twice.

So, I think I will land.

[Filip Pizlo]

Created attachment 340121 [details]
what the heck, let's try ews again

[Saam Barati]

(In reply to Filip Pizlo from comment #10)
> (In reply to Build Bot from comment #9)
> > Comment on attachment 340103 [details]
> > the patch
> > 
> > Attachment 340103 [details] did not pass jsc-ews (mac):
> > Output: http://webkit-queues.webkit.org/results/7640853
> > 
> > New failing tests:
> > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.dfg-eager-no-
> > cjit-validate
> > apiTests
> 
> It's very strange to see this failure.  I don't think it's related.  For
> example, it didn't happen on the earlier version of this patch, which was
> identical except for the changelog.  Also, I cannot get this failure on my
> system.  I tried twice.
> 
> So, I think I will land.

Yeah this isn't your patch. It's one of our sporadic (probably GC caused) failures:
https://bugs.webkit.org/show_bug.cgi?id=183266

[Filip Pizlo]

Landed in https://trac.webkit.org/changeset/231660/webkit

[Radar WebKit Bug Importer]

<rdar://problem/40142026>

[Yusuke Suzuki]

This also shows slight improvement in Octane/zlib :)