Bug 185442 - Do not apply X-Frame-Options and CSP frame-ancestors to Quick Look-applicable responses in NetworkProcess
Summary: Do not apply X-Frame-Options and CSP frame-ancestors to Quick Look-applicable...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on: 185410
Blocks:
  Show dependency treegraph
 
Reported: 2018-05-08 12:30 PDT by Daniel Bates
Modified: 2018-05-08 16:28 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.05 KB, patch)
2018-05-08 12:48 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (4.06 KB, patch)
2018-05-08 13:12 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (4.10 KB, patch)
2018-05-08 13:58 PDT, Daniel Bates
aestes: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-05-08 12:30:11 PDT
Do not apply X-Frame-Options and CSP frame-ancestors to QuickLooks-applicable responses in NetworkProcess.
Comment 1 Radar WebKit Bug Importer 2018-05-08 12:32:22 PDT
<rdar://problem/40067209>
Comment 2 Daniel Bates 2018-05-08 12:48:47 PDT
Created attachment 339857 [details]
Patch
Comment 3 Daniel Bates 2018-05-08 13:12:38 PDT
Created attachment 339860 [details]
Patch
Comment 4 Daniel Bates 2018-05-08 13:58:42 PDT
Created attachment 339871 [details]
Patch
Comment 5 Andy Estes 2018-05-08 16:12:35 PDT
Comment on attachment 339871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339871&action=review

> Source/WebKit/ChangeLog:9
> +        Just as we exempt responses in WebContent process that will be handled by QuickLooks from the Content

Quick Look, not QuickLooks
Comment 6 Daniel Bates 2018-05-08 16:24:27 PDT
(In reply to Andy Estes from comment #5)
> Comment on attachment 339871 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339871&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        Just as we exempt responses in WebContent process that will be handled by QuickLooks from the Content
> 
> Quick Look, not QuickLooks

Fixed bug title, will ChangeLog before landing.
Comment 7 Daniel Bates 2018-05-08 16:28:20 PDT
Committed r231521: <https://trac.webkit.org/changeset/231521>