RESOLVED FIXED 185440
Add tests to ensure that the Strong Password appearance is removed on form reset
https://bugs.webkit.org/show_bug.cgi?id=185440
Summary Add tests to ensure that the Strong Password appearance is removed on form reset
Daniel Bates
Reported 2018-05-08 12:01:03 PDT
Add a unit test to ensure that the embedding client is notified when the Strong Password appearance is removed on form reset.
Attachments
Tests (6.01 KB, patch)
2018-05-08 12:04 PDT, Daniel Bates
rniwa: review+
Daniel Bates
Comment 1 2018-05-08 12:02:49 PDT
(In reply to Daniel Bates from comment #0) > Add a unit test to ensure that the embedding client is notified when the > Strong Password appearance is removed on form reset. Actually we should add both a unit test and a layout test.
Daniel Bates
Comment 2 2018-05-08 12:04:12 PDT
Created attachment 339854 [details] Tests This patch depends on the refactoring done in the patch for bug #185433.
Ryosuke Niwa
Comment 3 2018-05-08 14:39:58 PDT
Comment on attachment 339854 [details] Tests View in context: https://bugs.webkit.org/attachment.cgi?id=339854&action=review > LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:14 > + let form = document.querySelector("form"); > + form.reset(); It seems like we don't need this local variable. Just do: document.querySelector("form").reset(). Or simply document.forms[0].reset()?
Daniel Bates
Comment 4 2018-05-08 16:18:09 PDT
(In reply to Ryosuke Niwa from comment #3) > Comment on attachment 339854 [details] > Tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339854&action=review > > > LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:14 > > + let form = document.querySelector("form"); > > + form.reset(); > > It seems like we don't need this local variable. > Just do: document.querySelector("form").reset(). Or simply > document.forms[0].reset()? Will fix before landing.
Daniel Bates
Comment 5 2018-05-08 16:19:43 PDT
(In reply to Daniel Bates from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Comment on attachment 339854 [details] > > Tests > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=339854&action=review > > > > > LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:14 > > > + let form = document.querySelector("form"); > > > + form.reset(); > > > > It seems like we don't need this local variable. > > Just do: document.querySelector("form").reset(). Or simply > > document.forms[0].reset()? > > Will fix before landing. Will use document.forms[0].reset().
Daniel Bates
Comment 6 2018-05-08 16:22:19 PDT
Radar WebKit Bug Importer
Comment 7 2018-05-08 16:23:19 PDT
Note You need to log in before you can comment on or make changes to this bug.