Add a unit test to ensure that the embedding client is notified when the Strong Password appearance is removed on form reset.
(In reply to Daniel Bates from comment #0) > Add a unit test to ensure that the embedding client is notified when the > Strong Password appearance is removed on form reset. Actually we should add both a unit test and a layout test.
Created attachment 339854 [details] Tests This patch depends on the refactoring done in the patch for bug #185433.
Comment on attachment 339854 [details] Tests View in context: https://bugs.webkit.org/attachment.cgi?id=339854&action=review > LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:14 > + let form = document.querySelector("form"); > + form.reset(); It seems like we don't need this local variable. Just do: document.querySelector("form").reset(). Or simply document.forms[0].reset()?
(In reply to Ryosuke Niwa from comment #3) > Comment on attachment 339854 [details] > Tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339854&action=review > > > LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:14 > > + let form = document.querySelector("form"); > > + form.reset(); > > It seems like we don't need this local variable. > Just do: document.querySelector("form").reset(). Or simply > document.forms[0].reset()? Will fix before landing.
(In reply to Daniel Bates from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Comment on attachment 339854 [details] > > Tests > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=339854&action=review > > > > > LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:14 > > > + let form = document.querySelector("form"); > > > + form.reset(); > > > > It seems like we don't need this local variable. > > Just do: document.querySelector("form").reset(). Or simply > > document.forms[0].reset()? > > Will fix before landing. Will use document.forms[0].reset().
Committed r231519: <https://trac.webkit.org/changeset/231519>
<rdar://problem/40075899>