Bug 185439 - System Preview links should trigger a download
Summary: System Preview links should trigger a download
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-08 11:44 PDT by Dean Jackson
Modified: 2018-05-08 13:26 PDT (History)
9 users (show)

See Also:

Attachments
Patch (15.47 KB, patch)
2018-05-08 11:53 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (15.59 KB, patch)
2018-05-08 12:02 PDT, Dean Jackson 		jonlee: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-05-08 11:44:29 PDT 
System Preview links should trigger a download
Comment 1 Radar WebKit Bug Importer 2018-05-08 11:45:19 PDT 
<rdar://problem/40065545>
Comment 2 Dean Jackson 2018-05-08 11:53:06 PDT 
Created attachment 339851 [details]
Patch
Comment 3 Dean Jackson 2018-05-08 12:02:30 PDT 
Created attachment 339853 [details]
Patch
Comment 4 Dean Jackson 2018-05-08 13:12:43 PDT 
Committed r231507: <https://trac.webkit.org/changeset/231507>
Comment 5 Simon Fraser (smfr) 2018-05-08 13:26:31 PDT 
Comment on attachment 339853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339853&action=review

> Source/WebCore/platform/network/ResourceRequestBase.cpp:587
> +void ResourceRequestBase::setSystemPreview(bool s)
> +{
> +    m_isSystemPreview = s;
> +}

s :(

> Source/WebCore/platform/network/ResourceRequestBase.h:236
> +    bool m_isSystemPreview { false };

Please move the bools together for better packing.