Bug 185437 - Log rtcstats as JSON
Summary: Log rtcstats as JSON
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-08 11:39 PDT by Eric Carlson
Modified: 2018-05-08 14:43 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.80 KB, patch)
2018-05-08 11:46 PDT, Eric Carlson
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (3.80 KB, patch)
2018-05-08 13:44 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.80 MB, application/zip)
2018-05-08 14:17 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.90 MB, application/zip)
2018-05-08 14:43 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-05-08 11:39:08 PDT
libwebrtc now emits stats as well formed JSON, so log them as JSON to the inspector console so they are easier to understand.
Comment 1 Radar WebKit Bug Importer 2018-05-08 11:39:46 PDT
<rdar://problem/40065332>
Comment 2 Eric Carlson 2018-05-08 11:46:22 PDT
Created attachment 339849 [details]
Patch
Comment 3 youenn fablet 2018-05-08 11:49:08 PDT
Comment on attachment 339849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339849&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1048
> +    RTCStatsLogger(const webrtc::RTCStats& stats)

explicit probably.

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1127
> +        return WTF::String(logger.toJSONString());

Do we need WTF::?
Comment 4 Eric Carlson 2018-05-08 13:44:07 PDT
Created attachment 339867 [details]
Patch for landing
Comment 5 EWS Watchlist 2018-05-08 14:16:56 PDT
Comment on attachment 339849 [details]
Patch

Attachment 339849 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7611407

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 6 EWS Watchlist 2018-05-08 14:17:08 PDT
Created attachment 339876 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 WebKit Commit Bot 2018-05-08 14:22:36 PDT
Comment on attachment 339867 [details]
Patch for landing

Clearing flags on attachment: 339867

Committed r231512: <https://trac.webkit.org/changeset/231512>
Comment 8 EWS Watchlist 2018-05-08 14:43:15 PDT
Comment on attachment 339849 [details]
Patch

Attachment 339849 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7612131

New failing tests:
http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
Comment 9 EWS Watchlist 2018-05-08 14:43:17 PDT
Created attachment 339883 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6