Bug 185437 – Log rtcstats as JSON

• Status: ASSIGNED
• Component: WebRTC

[Eric Carlson]

libwebrtc now emits stats as well formed JSON, so log them as JSON to the inspector console so they are easier to understand.

[Radar WebKit Bug Importer]

<rdar://problem/40065332>

[Eric Carlson]

Created attachment 339849 [details]
Patch

[youenn fablet]

Comment on attachment 339849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339849&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1048
> +    RTCStatsLogger(const webrtc::RTCStats& stats)

explicit probably.

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1127
> +        return WTF::String(logger.toJSONString());

Do we need WTF::?

[Eric Carlson]

Created attachment 339867 [details]
Patch for landing

[EWS Watchlist]

Comment on attachment 339849 [details]
Patch

Attachment 339849 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7611407

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html

[EWS Watchlist]

Created attachment 339876 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[WebKit Commit Bot]

Comment on attachment 339867 [details]
Patch for landing

Clearing flags on attachment: 339867

Committed r231512: <https://trac.webkit.org/changeset/231512>

[EWS Watchlist]

Comment on attachment 339849 [details]
Patch

Attachment 339849 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7612131

New failing tests:
http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html

[EWS Watchlist]

Created attachment 339883 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6