Bug 185427 – Add test to verify behavior of -webkit-text-fill-color when inherited

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Aditya Keerthi]

Add test to verify behavior of -webkit-text-fill-color when inherited

In the case where the parent element does not define -webkit-text-fill-color, and the child element has '-webkit-text-fill-color: inherit', the child element's computed -webkit-text-fill-color should be the parent's color. This is because the initial value of fill-color is currentcolor. The child then takes on the parent's currentcolor, which is equivalent to the parent's color.

[Aditya Keerthi]

Created attachment 339827 [details]
Patch

[Emilio Cobos Álvarez (:emilio)]

FWIW, at least per spec, currentColor isn't supposed to get resolved until resolved value time, so WebKit looks wrong here I think.

[Aditya Keerthi]

What would the expected behavior be in this case?

I was under the impression that currentcolor always takes on the value of the color attribute defined by the element.

[EWS Watchlist]

Comment on attachment 339827 [details]
Patch

Attachment 339827 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7610032

New failing tests:
css3/filters/backdrop/add-remove-add-backdrop-filter.html

[EWS Watchlist]

Created attachment 339856 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Aditya Keerthi]

Created attachment 340223 [details]
Patch

[Daniel Bates]

Comment on attachment 340223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340223&action=review

Thank you for iterating on this patch, Aditya.
r=me

> LayoutTests/fast/css/webkit-text-fill-color-inherit.html:5
> +        <div id="undefined-parent" style="color: red; -webkit-text-fill-color: inherit">Green</div>

This is OK as-is. We are not using this id.

> LayoutTests/fast/css/webkit-text-fill-color-inherit.html:8
> +        <div id="defined-parent" style="color: red; -webkit-text-fill-color: inherit">Green</div>

Ditto.

[WebKit Commit Bot]

Comment on attachment 340223 [details]
Patch

Clearing flags on attachment: 340223

Committed r231805: <https://trac.webkit.org/changeset/231805>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40259163>