Bug 185420 - [EME][GStreamer] Dispatch the protection event from AppendPipeline to MediaPlayer
Summary: [EME][GStreamer] Dispatch the protection event from AppendPipeline to MediaP...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-08 06:15 PDT by Yacine Bandou
Modified: 2018-05-10 18:26 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2018-05-08 07:06 PDT, Yacine Bandou
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yacine Bandou 2018-05-08 06:15:17 PDT
After the protection event support will be added in the bug 185245 the fucntion MediaPlayerPrivateGStreamerBase::handleProtectionEvent 
will be reached, so we should remove the ASSERT_NOT_REACHED.
Comment 1 Yacine Bandou 2018-05-08 07:06:49 PDT
Created attachment 339814 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-05-09 00:30:29 PDT
I think I explained myself poorly when I asked you to have this part of the code in a different bug. I meant that you should add the code to dispatch the event in a different bug other than the one for bug 185245. Would you have time to do it here?
Comment 3 Yacine Bandou 2018-05-09 02:54:12 PDT
The bug is renamed from "Avoid a crashes after the protection event
support is added in 185245" to "Dispatch the protection event from AppendPipeline to MediaPlayer" because I have removed the code which dispatches the Protection event from bug 185245 to this one.
Comment 4 Yacine Bandou 2018-05-10 18:26:40 PDT
For more detail see 185245