Bug 18540 - console.log('multiple', 'strings') quotes all strings after the first
Summary: console.log('multiple', 'strings') quotes all strings after the first
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://svn.webkit.org/repository/webk...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-16 13:20 PDT by Adam Roben (:aroben)
Modified: 2008-07-26 22:14 PDT (History)
0 users

See Also:


Attachments
fix (1.44 KB, patch)
2008-07-10 01:07 PDT, Keishi Hattori
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2008-04-16 13:20:53 PDT
console.log('multiple', 'strings') quotes all strings after the first one. For example:

console.log('here', 'are', 'some', 'strings')

Inspector's output:
here "are" "some" "strings"

Firebug's output:
here are some strings

We should match Firebug here.
Comment 1 Keishi Hattori 2008-07-10 01:07:05 PDT
Created attachment 22197 [details]
fix

Should I have written
    Object.type(parameters[i], InspectorController.inspectedWindow()) === "string"
instead of
    typeof parameters[i] === "string"
like on line 49 of Console.js?

I kind of feel using Object.type is an overkill for detecting string.
Comment 2 Adam Roben (:aroben) 2008-07-10 08:07:01 PDT
Comment on attachment 22197 [details]
fix

It would be great to add a testcase just for this particular problem (though the issue can already be seen in existing testcases)

r=me even without a testcase
Comment 3 Mark Rowe (bdash) 2008-07-26 22:14:27 PDT
Landed in r35383.