Bug 185398 – Web Inspector: split-up async stack trace test suite to improve clarity and maintainability

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Summary:
Split-up async stack trace test suite to improve clarity and maintainability. Currently this suite is marked '[ Pass Timeout ]', which can be removed since we'll be able to set test expectations at a finer level going forward.

[Radar WebKit Bug Importer]

<rdar://problem/40040289>

[Matt Baker]

Created attachment 339762 [details]
Patch

[EWS Watchlist]

Comment on attachment 339762 [details]
Patch

Attachment 339762 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7600057

New failing tests:
inspector/debugger/async-stack-trace-event-listener.html

[EWS Watchlist]

Created attachment 339772 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 339762 [details]
Patch

Attachment 339762 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7600124

New failing tests:
inspector/debugger/async-stack-trace-event-listener.html

[EWS Watchlist]

Created attachment 339773 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 339762 [details]
Patch

Attachment 339762 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7599918

New failing tests:
inspector/debugger/async-stack-trace-event-listener.html

[EWS Watchlist]

Created attachment 339776 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 339762 [details]
Patch

Attachment 339762 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7601882

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html

[EWS Watchlist]

Created attachment 339789 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Blaze Burg]

Comment on attachment 339762 [details]
Patch

This fails in EWS. Do you need to rebaseline or something?

[Matt Baker]

Created attachment 340227 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 340227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340227&action=review

Nice! r=me

> LayoutTests/inspector/debugger/async-stack-trace-basic.html:34
> +function triggerNestedSetTimeout() {
> +    setTimeout(function handleTimeout1() {
> +        setTimeout(function handleTimeout2() {
> +            debugger;
> +        });
> +    });
> +}

This is so very clean =)

> LayoutTests/inspector/debugger/async-stack-trace-basic.html:70
> +        expression: "triggerRequestAnimationFrame()",

Nit: We normally make strings that contain code templated strings. So use ``s instead of ""s. This ends up being convenient if your editor highlights strings and templated strings slightly differently, then the code snippets stand out!

> LayoutTests/inspector/debugger/async-stack-trace-truncate.html:82
> +        name: "AsyncStackTrace.",
> +        description: "",

More descriptive title?

[Matt Baker]

Comment on attachment 340227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340227&action=review

>> LayoutTests/inspector/debugger/async-stack-trace-truncate.html:82
>> +        description: "",
> 
> More descriptive title?

As in, any title at all? Hehe.

[Matt Baker]

Comment on attachment 340227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340227&action=review

>>> LayoutTests/inspector/debugger/async-stack-trace-truncate.html:82
>>> +        description: "",
>> 
>> More descriptive title?
> 
> As in, any title at all? Hehe.

Actually that last test is functionally identical to the one before. Looks like old copy paste junk. Will remove.

[Matt Baker]

Created attachment 346215 [details]
Patch for landing

[EWS Watchlist]

Comment on attachment 346215 [details]
Patch for landing

Attachment 346215 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8722268

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

[EWS Watchlist]

Created attachment 346271 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Matt Baker]

Created attachment 346664 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 346664 [details]
Patch for landing

Clearing flags on attachment: 346664

Committed r234635: <https://trac.webkit.org/changeset/234635>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.