Bug 185392 – test262/Runner.pm: create results dir for results of test262 run

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[valerie]

This patch:
- Creates a directory `results` and saves the results.yaml, summary.yaml and summary.txt files there
- adds a `--results` option to specify a results file, otherwise looks for a results directory wherever the script is ran

[valerie]

Created attachment 339749 [details]
Patch

[Michael Saboff]

Comment on attachment 339749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339749&action=review

> Tools/Scripts/test262/Runner.pm:91
> +$resultsDir = $resultsDir . "/results";

Let's change the results directory name to include test262.

[valerie]

Created attachment 339819 [details]
Patch

[EWS Watchlist]

Comment on attachment 339819 [details]
Patch

Attachment 339819 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7607461

New failing tests:
http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html

[EWS Watchlist]

Created attachment 339823 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Michael Saboff]

Comment on attachment 339819 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 339819 [details]
Patch

Rejecting attachment 339819 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 339819, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/test262/Runner.pm
Hunk #2 FAILED at 85.
Hunk #6 succeeded at 206 (offset -1 lines).
Hunk #7 succeeded at 903 (offset -1 lines).
1 out of 7 hunks FAILED -- saving rejects to file Tools/Scripts/test262/Runner.pm.rej
patching file .gitignore
patching file ChangeLog

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Michael Saboff']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/7608985

[valerie]

Created attachment 339858 [details]
Patch

[valerie]

Created attachment 339862 [details]
Patch

[valerie]

Created attachment 339864 [details]
Manually created patch for this bug

[valerie]

Created attachment 339865 [details]
Add test262-results dir

[valerie]

Created attachment 339870 [details]
Patch

[valerie]

Created attachment 339872 [details]
patch

[Michael Saboff]

Comment on attachment 339872 [details]
patch

r=me

[WebKit Commit Bot]

Comment on attachment 339872 [details]
patch

Clearing flags on attachment: 339872

Committed r231526: <https://trac.webkit.org/changeset/231526>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.