Bug 185391 - Use a dark gray for system preview background
Summary: Use a dark gray for system preview background
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-07 13:46 PDT by Dean Jackson
Modified: 2018-05-07 14:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2018-05-07 13:50 PDT, Dean Jackson 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-05-07 13:46:16 PDT 
Use a dark gray for system preview bbackground
Comment 1 Radar WebKit Bug Importer 2018-05-07 13:48:06 PDT 
<rdar://problem/40035120>
Comment 2 Dean Jackson 2018-05-07 13:50:51 PDT 
Created attachment 339748 [details]
Patch
Comment 3 Jon Lee 2018-05-07 13:53:25 PDT 
Comment on attachment 339748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review

> Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64
> +    UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1]

not being used?
Comment 4 Eric Carlson 2018-05-07 13:55:10 PDT 
Comment on attachment 339748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review

>> Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64
>> +    UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1]
> 
> not being used?

Ditto.
Comment 5 Dean Jackson 2018-05-07 13:56:02 PDT 
Comment on attachment 339748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review

>>> Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64
>>> +    UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1]
>> 
>> not being used?
> 
> Ditto.

Oh gosh. This patch is very wrong. It will make sense when I fix it.
Comment 6 Dean Jackson 2018-05-07 14:00:30 PDT 
Committed r231454: <https://trac.webkit.org/changeset/231454>