Bug 185388 - REGRESSION(r211075): Web Inspector throws an exception when inspecting WebViews on iOS 8.4 simulator
Summary: REGRESSION(r211075): Web Inspector throws an exception when inspecting WebVie...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-07 12:04 PDT by BJ Burg
Modified: 2022-03-01 02:28 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2018-05-07 12:06 PDT, BJ Burg
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-05-07 12:04:13 PDT
Missing a HeapAgent check.
Comment 1 BJ Burg 2018-05-07 12:06:22 PDT
Created attachment 339737 [details]
Patch
Comment 2 Joseph Pecoraro 2018-05-07 12:08:22 PDT
Comment on attachment 339737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339737&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:132
> -        if (HeapAgent.gc)
> +        // COMPATIBILITY (iOS 9): HeapAgent did not exist.
> +        if (WI.mainTarget.HeapAgent)

Normally this is just `if (window.HeapAgent)` I think its a little weird to use `WI.mainTarget`.