Bug 185377 – [LFC] Add FormattingContext::layoutOutOfFlowDescendants implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia.

[zalan]

Created attachment 339718 [details]
Patch

[Antti Koivisto]

Comment on attachment 339718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339718&action=review

> Source/WebCore/layout/FormattingContext.h:66
> -    const LayoutContext& layoutContext() const { return m_layoutContext; }
> +    LayoutContext& layoutContext() const { return m_layoutContext; }

I'm not sure I understand what the intention with constness here is. If LayoutContext is part of the FormattingContext and it is mutated during layout then functions like FormattingContext::layoutOutOfFlowDescendants() probably shouldn't be const in the first place.

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 339718 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339718&action=review
> 
> > Source/WebCore/layout/FormattingContext.h:66
> > -    const LayoutContext& layoutContext() const { return m_layoutContext; }
> > +    LayoutContext& layoutContext() const { return m_layoutContext; }
> 
> I'm not sure I understand what the intention with constness here is. If
> LayoutContext is part of the FormattingContext and it is mutated during
> layout then functions like FormattingContext::layoutOutOfFlowDescendants()
> probably shouldn't be const in the first place.
I think what I need to do here is to go back the original design when LayoutContext was passed in to FormattingContext::layout() (together with the mutable FormattingState). I changed it to a member while dealing with inherited floatings, but I think I can workaround that. FormattingContext::layout() will always mutate the (passed in) FormattingState by design. It also mutates the LayoutContext to construct Display::Boxes and generate new FormattingStates for the nested formatting contexts (and that is also by design)

[zalan]

Created attachment 339797 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 339797 [details]
Patch

Clearing flags on attachment: 339797

Committed r231480: <https://trac.webkit.org/changeset/231480>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40048933>