Bug 185376 - Update MediaSession to use release logging
Summary: Update MediaSession to use release logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-07 07:02 PDT by Eric Carlson
Modified: 2023-09-20 08:49 PDT (History)
4 users (show)

See Also:

Attachments
Patch (34.03 KB, patch)
2018-05-07 07:10 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (34.45 KB, patch)
2018-05-07 08:24 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (36.37 KB, patch)
2018-05-09 15:36 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-05-07 07:02:31 PDT 
Update MediaSession to use runtime logging
Comment 1 Radar WebKit Bug Importer 2018-05-07 07:03:27 PDT 
<rdar://problem/40022203>
Comment 2 Eric Carlson 2018-05-07 07:10:00 PDT 
Created attachment 339716 [details]
Patch
Comment 3 Eric Carlson 2018-05-07 08:24:59 PDT 
Created attachment 339723 [details]
Patch
Comment 4 youenn fablet 2018-05-07 09:19:50 PDT 
Comment on attachment 339723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339723&action=review

> Source/WebCore/html/MediaElementSession.cpp:135
> +        INFO_LOG(LOGIDENTIFIER, "adding ", restrictionName(restriction));

There might be cases where would want to log even if m_restrictions & restriction is true.
Shouldn't we inverse m_restrictions before doing the &?
Comment 5 Eric Carlson 2018-05-09 15:36:11 PDT 
Created attachment 340044 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-05-09 16:02:34 PDT 
Comment on attachment 340044 [details]
Patch for landing

Clearing flags on attachment: 340044

Committed r231604: <https://trac.webkit.org/changeset/231604>