Bug 185374 – [BigInt] Simplifying JSBigInt by using bool addition

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[BigInt] Simplifying JSBigInt by using bool addition

[Yusuke Suzuki]

Created attachment 339711 [details]
Patch

[Caio Lima]

Informal Review here. This LGTM. Thx for the Patch!

[EWS Watchlist]

Comment on attachment 339711 [details]
Patch

Attachment 339711 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7594268

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 339719 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Alex Christensen]

Comment on attachment 339711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339711&action=review

> Source/JavaScriptCore/runtime/JSBigInt.cpp:263
> +    carry += static_cast<bool>(result < a);

I'm not sure if the static_cast<bool>s are necessary

[Yusuke Suzuki]

Comment on attachment 339711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339711&action=review

Thanks!

>> Source/JavaScriptCore/runtime/JSBigInt.cpp:263
>> +    carry += static_cast<bool>(result < a);
> 
> I'm not sure if the static_cast<bool>s are necessary

This is not necessary. In C++, bool to unsigned value is guaranteed (true -> 1, false -> 0). But to make this intent explicit, I think having `static_cast<bool>` is nice.

[Yusuke Suzuki]

Committed r231546: <https://trac.webkit.org/changeset/231546>

[Radar WebKit Bug Importer]

<rdar://problem/40083720>