Bug 185371 – [DFG][MIPS] Simplify DFG code by increasing MIPS temporary registers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[DFG][MIPS] Simplify DFG code by increasing MIPS temporary registers

[Yusuke Suzuki]

Created attachment 339706 [details]
Patch

[EWS Watchlist]

Comment on attachment 339706 [details]
Patch

Attachment 339706 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7592820

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 339712 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Yusuke Suzuki]

(In reply to Build Bot from comment #3)
> Created attachment 339712 [details]
> Archive of layout-test-results from ews206 for win-future
> 
> The attached test failures were seen while running run-webkit-tests on the
> win-ews.
> Bot: ews206  Port: win-future  Platform:
> CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Unrelated to Windows

[Dominik Inführ]

Thanks for working on this! Not sure if you have access to a MIPS system, so just in case I've built the patch and run all tests successfully on MIPS.

Could the expression `#if CPU(X86) && USE(JSVALUE32_64)` be simplified to `#if CPU(X86)`?

[Yusuke Suzuki]

(In reply to Dominik Inführ from comment #5)
> Thanks for working on this! Not sure if you have access to a MIPS system, so
> just in case I've built the patch and run all tests successfully on MIPS.
> 
> Could the expression `#if CPU(X86) && USE(JSVALUE32_64)` be simplified to
> `#if CPU(X86)`?

Nice. I don’t have any MIPS machines. I’m happy to hear that it works.

[Mark Lam]

Comment on attachment 339706 [details]
Patch

LGTM.

[Yusuke Suzuki]

(In reply to Dominik Inführ from comment #5)
> Could the expression `#if CPU(X86) && USE(JSVALUE32_64)` be simplified to
> `#if CPU(X86)`?

Changed. This part depends on the number of registers. So rather than using USE(JSVALUE32_64), using CPU(X86) is better.

[Yusuke Suzuki]

Committed r231472: <https://trac.webkit.org/changeset/231472>

[Radar WebKit Bug Importer]

<rdar://problem/40045024>