Bug 185365 - InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
Summary: InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract va...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-06 13:43 PDT by Filip Pizlo
Modified: 2018-05-08 14:49 PDT (History)
11 users (show)

See Also:

Attachments
the patch (23.28 KB, patch)
2018-05-06 13:47 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-05-06 13:43:22 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2018-05-06 13:47:01 PDT 
Created attachment 339690 [details]
the patch
Comment 2 EWS Watchlist 2018-05-06 13:49:11 PDT 
Attachment 339690 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGGraph.h:87:  _edgeIndex is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/dfg/DFGGraph.h:88:  _edge is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2018-05-07 15:31:32 PDT 
Comment on attachment 339690 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339690&action=review

r=me

> Source/WTF/wtf/TinyPtrSet.h:30
> +#include <wtf/DataLog.h>

no need for this.

> Tools/ChangeLog:8
> +        Make it possible to measure compile times.

nice!
Comment 4 Filip Pizlo 2018-05-07 17:07:44 PDT 
Landed in https://trac.webkit.org/changeset/231468/webkit
Comment 5 Radar WebKit Bug Importer 2018-05-07 17:12:03 PDT 
<rdar://problem/40043054>
Comment 6 Ryan Haddad 2018-05-07 17:17:15 PDT 
This change broke the CLoop build:

/Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/jsc.cpp:1816:37: error: use of undeclared identifier 'JIT'
    return JSValue::encode(jsNumber(JIT::totalCompileTime().milliseconds()));

https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/5711
Comment 7 Ryan Haddad 2018-05-08 10:53:00 PDT 
Reverted r231468 for reason:

Broke the CLoop build

Committed r231492: <https://trac.webkit.org/changeset/231492>
Comment 8 Filip Pizlo 2018-05-08 14:49:46 PDT 
Landed in https://trac.webkit.org/changeset/231514/webkit