Bug 185356 - Draw a drop-shadow behind the system preview badge
Summary: Draw a drop-shadow behind the system preview badge
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-05 14:50 PDT by Dean Jackson
Modified: 2018-05-06 17:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.59 KB, patch)
2018-05-05 15:02 PDT, Dean Jackson 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-05-05 14:50:26 PDT 
Draw a drop-shadow behind the system preview badge
Comment 1 Radar WebKit Bug Importer 2018-05-05 14:51:47 PDT 
<rdar://problem/40004936>
Comment 2 Dean Jackson 2018-05-05 15:02:00 PDT 
Created attachment 339656 [details]
Patch
Comment 3 Wenson Hsieh 2018-05-05 15:19:34 PDT 
Comment on attachment 339656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339656&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1853
> +    RetainPtr<CGPathRef> circle = adoptCF(CGPathCreateWithRoundedRect(absoluteBadgeRect, badgeDimension / 2, badgeDimension / 2, nullptr));

Nit - I think we generally auto these.
Comment 4 Dean Jackson 2018-05-05 15:43:16 PDT 
Committed r231397: <https://trac.webkit.org/changeset/231397>
Comment 5 Darin Adler 2018-05-06 17:06:40 PDT 
Comment on attachment 339656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339656&action=review

>> Source/WebCore/rendering/RenderThemeIOS.mm:1853
>> +    RetainPtr<CGPathRef> circle = adoptCF(CGPathCreateWithRoundedRect(absoluteBadgeRect, badgeDimension / 2, badgeDimension / 2, nullptr));
> 
> Nit - I think we generally auto these.

I often work with both of you on WebKit and I endorse this message.