Bug 185347 – [Extra zoom mode] Google search results are excessively zoomed in

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Wenson Hsieh]

Subject says it all.

[Radar WebKit Bug Importer]

<rdar://problem/39999778>

[Wenson Hsieh]

Created attachment 339660 [details]
Patch

[EWS Watchlist]

Comment on attachment 339660 [details]
Patch

Attachment 339660 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7581212

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html

[EWS Watchlist]

Created attachment 339665 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Wenson Hsieh]

Comment on attachment 339665 [details]
Archive of layout-test-results from ews200 for win-future

Test failure seems unrelated.

[Wenson Hsieh]

Created attachment 339913 [details]
Patch

[Wenson Hsieh]

Created attachment 339915 [details]
Rebase on trunk

[Wenson Hsieh]

Created attachment 339919 [details]
Actually rebase on trunk

[Wenson Hsieh]

Comment on attachment 339919 [details]
Actually rebase on trunk

This is no longer the approach we’re planning to take.

[Wenson Hsieh]

Created attachment 340340 [details]
Patch

[Wenson Hsieh]

Created attachment 340349 [details]
Try to fix non-internal builds

[WebKit Commit Bot]

Comment on attachment 340349 [details]
Try to fix non-internal builds

Clearing flags on attachment: 340349

Committed r231779: <https://trac.webkit.org/changeset/231779>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Frédéric Wang (:fredw)]

Comment on attachment 340349 [details]
Try to fix non-internal builds

View in context: https://bugs.webkit.org/attachment.cgi?id=340349&action=review

> Source/WebCore/page/WindowFeatures.h:63
> +OptionSet<DisabledAdaptations> parseDisabledAdaptations(const String&);

It looks WindowFeatures.cpp|h needed the <wtf/OptionSet.h> header. At least I got build error with rotating unified source. I just landed a fix for that.

[Wenson Hsieh]

(In reply to Frédéric Wang (:fredw) from comment #14)
> Comment on attachment 340349 [details]
> Try to fix non-internal builds
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340349&action=review
> 
> > Source/WebCore/page/WindowFeatures.h:63
> > +OptionSet<DisabledAdaptations> parseDisabledAdaptations(const String&);
> 
> It looks WindowFeatures.cpp|h needed the <wtf/OptionSet.h> header. At least
> I got build error with rotating unified source. I just landed a fix for that.

Sorry — thanks for the fix!