Bug 185344 – Cleanup XMLHttpRequestUpload a little

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Cleanup XMLHttpRequestUpload a little

[Sam Weinig]

Created attachment 339636 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 339636 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 339636 [details]
Patch

Clearing flags on attachment: 339636

Committed r231398: <https://trac.webkit.org/changeset/231398>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 339636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339636&action=review

> Source/WebCore/xml/XMLHttpRequestUpload.h:45
> +    EventTargetInterface eventTargetInterface() const override { return XMLHttpRequestUploadEventTargetInterfaceType; }
> +    ScriptExecutionContext* scriptExecutionContext() const override { return m_xmlHttpRequest.scriptExecutionContext(); }

I’d have made these private, and used final instead of override.

> Source/WebCore/xml/XMLHttpRequestUpload.h:54
> +    XMLHttpRequest& m_xmlHttpRequest;

We should rename this to m_request or m_underlyingRequest. I think maybe the member function too.

> Source/WebCore/xml/XMLHttpRequestUpload.h:57
> +    bool m_lengthComputable { false };
> +    unsigned long long m_loaded { 0 };
> +    unsigned long long m_total { 0 };

I really don’t like these names, but they are straight out of the progress event specification. I kind of wish this was a ProgressEvent::Init structure. But that also has Event::Init as its base class.

[Radar WebKit Bug Importer]

<rdar://problem/40011842>