Bug 185334 - Shift to a lower-level framework for simplifying URLs
Summary: Shift to a lower-level framework for simplifying URLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-04 16:16 PDT by Tim Horton
Modified: 2018-05-04 17:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (21.98 KB, patch)
2018-05-04 16:17 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (22.06 KB, patch)
2018-05-04 16:38 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-05-04 16:16:30 PDT
Shift to a lower-level framework for simplifying URLs
Comment 1 Tim Horton 2018-05-04 16:17:20 PDT
Created attachment 339606 [details]
Patch
Comment 2 mitz 2018-05-04 16:23:12 PDT
Comment on attachment 339606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339606&action=review

> Source/WebCore/platform/mac/DragImageMac.mm:-47
> -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300

Not clear why we’d want to try to use Link Presentation prior to macOS 10.13.
Comment 3 Tim Horton 2018-05-04 16:32:54 PDT
Comment on attachment 339606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339606&action=review

>> Source/WebCore/platform/mac/DragImageMac.mm:-47
>> -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
> 
> Not clear why we’d want to try to use Link Presentation prior to macOS 10.13.

Not clear why I picked 10.13 originally, LinkPresentation is available in 10.12 and the method we use in 10.12.3. I don't think we build back that far anymore (at least, as far as I can tell, we always build with the biggest point update, and only back to 10.12.x).
Comment 4 Tim Horton 2018-05-04 16:38:48 PDT
Created attachment 339612 [details]
Patch
Comment 5 WebKit Commit Bot 2018-05-04 17:16:23 PDT
Comment on attachment 339612 [details]
Patch

Clearing flags on attachment: 339612

Committed r231393: <https://trac.webkit.org/changeset/231393>
Comment 6 WebKit Commit Bot 2018-05-04 17:16:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-04 17:17:25 PDT
<rdar://problem/39994948>