Bug 185329 – Make a compact version of VariableEnvironment that UnlinkedFunctionExecutable stores and hash-cons these compact environments as we make them

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

....

[Saam Barati]

Created attachment 339653 [details]
WIP

seems to work, just need to clean up a few things.

[EWS Watchlist]

Attachment 339653 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/VM.cpp:145:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

(In reply to Saam Barati from comment #1)
> Created attachment 339653 [details]
> WIP
> 
> seems to work, just need to clean up a few things.

Seems to be a 50-60MB improvement on the workload I am testing

[Saam Barati]

Created attachment 339765 [details]
patch

[EWS Watchlist]

Attachment 339765 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/VM.cpp:145:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

<rdar://problem/39961536>

[Michael Saboff]

Comment on attachment 339765 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339765&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        use space to represent and UnlinkedFunctionExecutable's parent TDZ variables.

*an*

> Source/JavaScriptCore/parser/VariableEnvironment.cpp:101
> +    m_isEverythingCaptured = env.isEverythingCaptured();

Change this to a member initializer list.

[Mark Lam]

Comment on attachment 339765 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339765&action=review

> Source/JavaScriptCore/parser/VariableEnvironment.h:205
> +        WTF_MAKE_NONCOPYABLE(Handle); // If we wanted to make this copyable, we'd need to do a hashtable lookup and bump the refcount.

/refcount/refCount/?

[Saam Barati]

Created attachment 339788 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 339788 [details]
patch for landing

Clearing flags on attachment: 339788

Committed r231477: <https://trac.webkit.org/changeset/231477>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.