Bug 185325 - [Win] Add missing methods to WebChromeClient
Summary: [Win] Add missing methods to WebChromeClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 174003
  Show dependency tree / graph
 
Reported: 2018-05-04 14:39 PDT by Don Olmstead
Modified: 2018-05-07 12:43 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2018-05-04 14:44 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-05-04 14:39:41 PDT 
WebChromeClient is currently missing the following methods for PLATFORM(WIN)

void setLastSetCursorToCurrentCursor()
void AXStartFrameLoad()
void AXFinishFrameLoad()
Comment 1 Don Olmstead 2018-05-04 14:44:29 PDT 
Created attachment 339596 [details]
Patch

Add method stubs so WebChromeClient can be used.
Comment 2 Brent Fulgham 2018-05-07 12:14:41 PDT 
Comment on attachment 339596 [details]
Patch

Looks good. r=me
Comment 3 WebKit Commit Bot 2018-05-07 12:42:59 PDT 
Comment on attachment 339596 [details]
Patch

Clearing flags on attachment: 339596

Committed r231451: <https://trac.webkit.org/changeset/231451>
Comment 4 WebKit Commit Bot 2018-05-07 12:43:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-05-07 12:43:17 PDT 
<rdar://problem/40032761>