Bug 185318 - [iOS] Apps that are not visible may not get suspended if they trigger page loads while in the background
Summary: [iOS] Apps that are not visible may not get suspended if they trigger page lo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 185333
  Show dependency tree / graph
 
Reported: 2018-05-04 12:55 PDT by Chris Dumez
Modified: 2018-10-09 16:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2018-05-04 13:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.56 KB, patch)
2018-05-04 13:01 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.40 KB, patch)
2018-05-10 13:02 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-05-04 12:55:10 PDT 
Apps that are not visible may not get suspended if they trigger a page loads.
Comment 1 Chris Dumez 2018-05-04 13:00:27 PDT 
Created attachment 339584 [details]
Patch
Comment 2 Chris Dumez 2018-05-04 13:01:32 PDT 
Created attachment 339585 [details]
Patch
Comment 3 Geoffrey Garen 2018-05-04 13:35:43 PDT 
Comment on attachment 339585 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-05-04 13:48:29 PDT 
Comment on attachment 339585 [details]
Patch

Clearing flags on attachment: 339585

Committed r231376: <https://trac.webkit.org/changeset/231376>
Comment 5 WebKit Commit Bot 2018-05-04 13:48:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-05-04 13:49:19 PDT 
<rdar://problem/39987839>
Comment 7 Ryan Haddad 2018-05-08 11:06:46 PDT 
This change seems to have caused API test failures and timeouts on iOS Simulator:
https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/4803

I cannot repro with a build of r231375, but I can with a build of r231376.
Comment 8 Ryan Haddad 2018-05-08 11:24:34 PDT 
I attempted to roll this out, but https://trac.webkit.org/changeset/231458/webkit conflicts.
Comment 9 Chris Dumez 2018-05-08 11:53:16 PDT 
(In reply to Ryan Haddad from comment #8)
> I attempted to roll this out, but
> https://trac.webkit.org/changeset/231458/webkit conflicts.

Arg. Ok, Will investigate now then.
Comment 10 Chris Dumez 2018-05-08 11:58:30 PDT 
Committed r231498: <https://trac.webkit.org/changeset/231498>
Comment 11 Chris Dumez 2018-05-08 11:59:05 PDT 
Rolled out in <https://trac.webkit.org/changeset/231498>.
Comment 12 Chris Dumez 2018-05-10 13:02:49 PDT 
Created attachment 340119 [details]
Patch
Comment 13 Geoffrey Garen 2018-05-10 14:38:11 PDT 
Comment on attachment 340119 [details]
Patch

r=me
Comment 14 WebKit Commit Bot 2018-05-10 15:02:37 PDT 
Comment on attachment 340119 [details]
Patch

Clearing flags on attachment: 340119

Committed r231663: <https://trac.webkit.org/changeset/231663>
Comment 15 WebKit Commit Bot 2018-05-10 15:02:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 16 Alex Christensen 2018-10-09 16:37:48 PDT 
I'm reverting this in https://bugs.webkit.org/show_bug.cgi?id=190417