Bug 185316 - Fix Tools/Scripts/webkitdirs.pm for retrocompatibility
Summary: Fix Tools/Scripts/webkitdirs.pm for retrocompatibility
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-04 12:07 PDT by Leo Balter
Modified: 2018-05-07 15:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2018-05-04 12:08 PDT, Leo Balter 		ap: review-
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Balter 2018-05-04 12:07:45 PDT 
Fix Tools/Scripts/webkitdirs.pm for retrocompatibility
Comment 1 Leo Balter 2018-05-04 12:08:22 PDT 
Created attachment 339579 [details]
Patch
Comment 2 Leo Balter 2018-05-04 12:11:17 PDT 
the `use version` is not really necessary for this script and it's not present before Perl 5.10.

This script is indirectly called by the Test262 Runner where Perl 5.8.8 is required.
Comment 3 Alexey Proskuryakov 2018-05-04 13:28:40 PDT 
Could you please explain the situation in more detail?

We use webkitdirs.pm everywhere, so it is very surprising that there is an environment where we need to use test262 runner, but haven’t been using webkitdirs fringe forever already.
Comment 4 Alexey Proskuryakov 2018-05-04 13:30:16 PDT 
*since forever
Comment 5 Leo Balter 2018-05-07 10:42:26 PDT 
Hi Alexey,

After discussing this feedback internally, we believe it's best to not require any other shared script so the 5.8.8 limitation goes isolated for the t262 runner only.

I can talk more about using the environments test262 runner - mostly through the CI processes, but I'm afraid this could sidetrack the patch here. You can ping me on my email leo at bocoup.com and I'd be happy to give more details.
Comment 6 Alexey Proskuryakov 2018-05-07 15:02:07 PDT 
Comment on attachment 339579 [details]
Patch

Marking r-, as the issue is now NTBF.