RESOLVED WONTFIX185316
Fix Tools/Scripts/webkitdirs.pm for retrocompatibility 
https://bugs.webkit.org/show_bug.cgi?id=185316
Summary Fix Tools/Scripts/webkitdirs.pm for retrocompatibility
Leo Balter
Reported 2018-05-04 12:07:45 PDT
Fix Tools/Scripts/webkitdirs.pm for retrocompatibility
Attachments
Patch (2.02 KB, patch)
2018-05-04 12:08 PDT, Leo Balter 		ap: review-
ap: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leo Balter
Comment 1 2018-05-04 12:08:22 PDT
Created attachment 339579 [details] Patch
Leo Balter
Comment 2 2018-05-04 12:11:17 PDT
the `use version` is not really necessary for this script and it's not present before Perl 5.10. This script is indirectly called by the Test262 Runner where Perl 5.8.8 is required.
Alexey Proskuryakov
Comment 3 2018-05-04 13:28:40 PDT
Could you please explain the situation in more detail? We use webkitdirs.pm everywhere, so it is very surprising that there is an environment where we need to use test262 runner, but haven’t been using webkitdirs fringe forever already.
Alexey Proskuryakov
Comment 4 2018-05-04 13:30:16 PDT
*since forever
Leo Balter
Comment 5 2018-05-07 10:42:26 PDT
Hi Alexey, After discussing this feedback internally, we believe it's best to not require any other shared script so the 5.8.8 limitation goes isolated for the t262 runner only. I can talk more about using the environments test262 runner - mostly through the CI processes, but I'm afraid this could sidetrack the patch here. You can ping me on my email leo at bocoup.com and I'd be happy to give more details.
Alexey Proskuryakov
Comment 6 2018-05-07 15:02:07 PDT
Comment on attachment 339579 [details] Patch Marking r-, as the issue is now NTBF.
Note You need to log in before you can comment on or make changes to this bug.