Bug 185310 - Wasted time dlopening Lookup when tearing down a WKWebView
Summary: Wasted time dlopening Lookup when tearing down a WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-04 11:21 PDT by Tim Horton
Modified: 2018-05-04 12:42 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.12 KB, patch)
2018-05-04 11:21 PDT, Tim Horton
wenson_hsieh: review+
Details | Formatted Diff | Diff
patch for landing (4.11 KB, patch)
2018-05-04 12:05 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-05-04 11:21:26 PDT
Wasted time dlopening Lookup when tearing down a WKWebView
Comment 1 Tim Horton 2018-05-04 11:21:41 PDT
Created attachment 339569 [details]
Patch
Comment 2 Tim Horton 2018-05-04 11:22:25 PDT
rdar://problem/39934085
Comment 3 Wenson Hsieh 2018-05-04 11:59:11 PDT
Comment on attachment 339569 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339569&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:293
> +    _didRegisterForLookupPopoverCloseNotifications = true;

Nit - _didRegisterForLookupPopoverCloseNotifications = YES; (or bool _didRegisterForLookupPopoverCloseNotifications)
Comment 4 Tim Horton 2018-05-04 12:03:37 PDT
Of course!
Comment 5 Tim Horton 2018-05-04 12:05:13 PDT
Created attachment 339578 [details]
patch for landing
Comment 6 WebKit Commit Bot 2018-05-04 12:42:46 PDT
Comment on attachment 339578 [details]
patch for landing

Clearing flags on attachment: 339578

Committed r231371: <https://trac.webkit.org/changeset/231371>
Comment 7 WebKit Commit Bot 2018-05-04 12:42:48 PDT
All reviewed patches have been landed.  Closing bug.