RESOLVED FIXED 185310
Wasted time dlopening Lookup when tearing down a WKWebView 
https://bugs.webkit.org/show_bug.cgi?id=185310
Summary Wasted time dlopening Lookup when tearing down a WKWebView
Tim Horton
Reported 2018-05-04 11:21:26 PDT
Wasted time dlopening Lookup when tearing down a WKWebView
Attachments
Patch (4.12 KB, patch)
2018-05-04 11:21 PDT, Tim Horton 		wenson_hsieh: review+
DetailsFormatted DiffDiff
patch for landing (4.11 KB, patch)
2018-05-04 12:05 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-05-04 11:21:41 PDT
Created attachment 339569 [details] Patch
Tim Horton
Comment 2 2018-05-04 11:22:25 PDT
rdar://problem/39934085
Wenson Hsieh
Comment 3 2018-05-04 11:59:11 PDT
Comment on attachment 339569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339569&action=review > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:293 > + _didRegisterForLookupPopoverCloseNotifications = true; Nit - _didRegisterForLookupPopoverCloseNotifications = YES; (or bool _didRegisterForLookupPopoverCloseNotifications)
Tim Horton
Comment 4 2018-05-04 12:03:37 PDT
Of course!
Tim Horton
Comment 5 2018-05-04 12:05:13 PDT
Created attachment 339578 [details] patch for landing
WebKit Commit Bot
Comment 6 2018-05-04 12:42:46 PDT
Comment on attachment 339578 [details] patch for landing Clearing flags on attachment: 339578 Committed r231371: <https://trac.webkit.org/changeset/231371>
WebKit Commit Bot
Comment 7 2018-05-04 12:42:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.