Bug 185301 - [LFC] Set the invalidation root as the result of style change.
Summary: [LFC] Set the invalidation root as the result of style change.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-04 07:49 PDT by zalan
Modified: 2018-05-04 09:31 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.34 KB, patch)
2018-05-04 08:01 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (13.63 KB, patch)
2018-05-04 09:14 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-05-04 07:49:15 PDT
ssia
Comment 1 zalan 2018-05-04 08:01:31 PDT
Created attachment 339544 [details]
Patch
Comment 2 Antti Koivisto 2018-05-04 08:13:26 PDT
Comment on attachment 339544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339544&action=review

> Source/WebCore/layout/inlineformatting/InlineInvalidation.h:46
> -    static void invalidate(const Box&, StyleDiff, LayoutContext&, InlineFormattingState&);
> +    static const Container* invalidate(const Box&, StyleDiff, LayoutContext&, InlineFormattingState&);

It is bit unclear what the return value is here. Maybe 'invalidateAndComputeRoot' or something? Or just a comment.
Comment 3 zalan 2018-05-04 09:14:34 PDT
Created attachment 339549 [details]
Patch
Comment 4 WebKit Commit Bot 2018-05-04 09:30:34 PDT
Comment on attachment 339549 [details]
Patch

Clearing flags on attachment: 339549

Committed r231355: <https://trac.webkit.org/changeset/231355>
Comment 5 WebKit Commit Bot 2018-05-04 09:30:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-05-04 09:31:20 PDT
<rdar://problem/39978603>