Bug 185297 - Improve test at media/modern-media-controls/airplay-button/airplay-button-on.html to not hardcode the -apple-wireless-playback-target-active color
Summary: Improve test at media/modern-media-controls/airplay-button/airplay-button-on....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-04 04:46 PDT by Antoine Quint
Modified: 2018-05-04 10:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.15 KB, patch)
2018-05-04 04:49 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.70 MB, application/zip)
2018-05-04 09:43 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-05-04 04:46:44 PDT 
The test at media/modern-media-controls/airplay-button/airplay-button-on.html uses navigator.platform to determine what the RGB color for -apple-wireless-playback-target-active is. We should instead query it from another element using the CSSOM to always get the correct value.
Comment 1 Antoine Quint 2018-05-04 04:46:58 PDT 
<rdar://problem/39737716>
Comment 2 Antoine Quint 2018-05-04 04:49:00 PDT 
Created attachment 339536 [details]
Patch
Comment 3 EWS Watchlist 2018-05-04 09:43:10 PDT 
Comment on attachment 339536 [details]
Patch

Attachment 339536 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7564821

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 4 EWS Watchlist 2018-05-04 09:43:21 PDT 
Created attachment 339555 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 WebKit Commit Bot 2018-05-04 10:21:27 PDT 
Comment on attachment 339536 [details]
Patch

Clearing flags on attachment: 339536

Committed r231357: <https://trac.webkit.org/changeset/231357>
Comment 6 WebKit Commit Bot 2018-05-04 10:21:29 PDT 
All reviewed patches have been landed.  Closing bug.