Bug 185292 - Remove std::random_shuffle
Summary: Remove std::random_shuffle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 185293
  Show dependency tree / graph
 
Reported: 2018-05-03 21:46 PDT by Yusuke Suzuki
Modified: 2018-05-03 22:33 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.77 KB, patch)
2018-05-03 21:47 PDT, Yusuke Suzuki 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-05-03 21:46:25 PDT 
Remove std::random_shuffle
Comment 1 Yusuke Suzuki 2018-05-03 21:47:10 PDT 
Created attachment 339520 [details]
Patch
Comment 2 Filip Pizlo 2018-05-03 22:19:21 PDT 
Comment on attachment 339520 [details]
Patch

Can we instead have a WeakRandon rwference passed to BinarySwitch?  Maybe users of BinarySwitch can keep a WeakRandom around longer.
Comment 3 Darin Adler 2018-05-03 22:22:58 PDT 
(In reply to Filip Pizlo from comment #2)
> Can we instead have a WeakRandon rwference passed to BinarySwitch?  Maybe
> users of BinarySwitch can keep a WeakRandom around longer.

Seems OK, but this is not changing here, so seems orthogonal.
Comment 4 Yusuke Suzuki 2018-05-03 22:31:13 PDT 
(In reply to Filip Pizlo from comment #2)
> Comment on attachment 339520 [details]
> Patch
> 
> Can we instead have a WeakRandon rwference passed to BinarySwitch?  Maybe
> users of BinarySwitch can keep a WeakRandom around longer.

OK, I'll do this that in a separate patch. This patch removes std::random_shuffle, this is required b/c C++17 removes this function, and actually MSVC w/ C++17 flag does not have this function :)
Comment 5 Yusuke Suzuki 2018-05-03 22:32:46 PDT 
Committed r231347: <https://trac.webkit.org/changeset/231347>
Comment 6 Radar WebKit Bug Importer 2018-05-03 22:33:27 PDT 
<rdar://problem/39967119>