Bug 185290 - Rename DocumentOrderedMap to TreeScopeOrderedMap
Summary: Rename DocumentOrderedMap to TreeScopeOrderedMap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-03 20:48 PDT by Ryosuke Niwa
Modified: 2018-05-04 16:53 PDT (History)
10 users (show)

See Also:


Attachments
Cleanup (11.61 KB, patch)
2018-05-03 20:52 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (45.49 KB, patch)
2018-05-04 14:25 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-05-03 20:48:10 PDT
It's a mistake to use DocumentOrderedMap in Document. Rename the class to make this clear.
Comment 1 Ryosuke Niwa 2018-05-03 20:52:38 PDT
Created attachment 339517 [details]
Cleanup
Comment 2 Ryosuke Niwa 2018-05-04 14:25:41 PDT
Created attachment 339595 [details]
Patch for landing
Comment 3 Ryosuke Niwa 2018-05-04 14:25:59 PDT
Comment on attachment 339595 [details]
Patch for landing

Wait for EWS.
Comment 4 EWS Watchlist 2018-05-04 14:27:56 PDT
Attachment 339595 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/TreeScopeOrderedMap.cpp:53:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/dom/TreeScopeOrderedMap.cpp:63:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/dom/TreeScopeOrderedMap.cpp:84:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/dom/TreeScopeOrderedMap.cpp:111:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/dom/TreeScopeOrderedMap.cpp:121:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 5 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Ryosuke Niwa 2018-05-04 16:52:46 PDT
Committed r231390: <https://trac.webkit.org/changeset/231390>
Comment 6 Radar WebKit Bug Importer 2018-05-04 16:53:16 PDT
<rdar://problem/39994362>