Bug 185281 – OSR entry pruning of Program Bytecodes doesn't take into account try/catch

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

In the baseline, we have an optimization where we prune unreachable code beginning from the instruction we OSR entry to.  This pruning needs to take into account the reachability from local catch statements.

[Michael Saboff]

<rdar://problem/39456551>

[Michael Saboff]

Created attachment 339494 [details]
Patch

[Michael Saboff]

Created attachment 339497 [details]
Updated Patch

[Saam Barati]

Comment on attachment 339497 [details]
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339497&action=review

r=me

> Source/JavaScriptCore/jit/JIT.cpp:203
> +

please delete.

> Source/JavaScriptCore/jit/JIT.cpp:228
> +                for (unsigned bytecodeOffset = block->leaderOffset(); bytecodeOffset < block->leaderOffset() + block->totalLength();) {

Can we skip this loop if the program has no catch handlers?

[Michael Saboff]

(In reply to Saam Barati from comment #4)
> Comment on attachment 339497 [details]
> Updated Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339497&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/jit/JIT.cpp:203
> > +
> 
> please delete.
> 
> > Source/JavaScriptCore/jit/JIT.cpp:228
> > +                for (unsigned bytecodeOffset = block->leaderOffset(); bytecodeOffset < block->leaderOffset() + block->totalLength();) {
> 
> Can we skip this loop if the program has no catch handlers?

I'll take care of those changes locally before landing.

[Michael Saboff]

Committed r231343: <https://trac.webkit.org/changeset/231343>