Bug 185279 – Deprecate legacy WebView and friends

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Timothy Hatcher]

<rdar://problem/33268700>

[Timothy Hatcher]

Created attachment 339492 [details]
Patch

[Tim Horton]

Comment on attachment 339492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339492&action=review

> Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:30
> +// Declare this as a system header to avoid WebView deprecation
> +// warnings in this header when building Safari locally.

This feels like a weird comment to have in a private header but there are other weird comments below so whatever.

[Tim Horton]

Comment on attachment 339492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339492&action=review

> Source/WebCore/ChangeLog:14
> +        Added more macros and wa way to disable deprecation warnings for

wa?

Comment on attachment 339492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339492&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:28
> +GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) $(FEATURE_DEFINES) __BUILDING_WEBKIT U_DISABLE_RENAMING=1 U_SHOW_CPLUSPLUS_API=0 GL_SILENCE_DEPRECATION=1 GLES_SILENCE_DEPRECATION=1 $(inherited);

Seems strange to use something from the reserved namespace of identifiers that are prefixed with two underscores.

> Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h:31
> +#pragma clang system_header

Seems like this should be Safari’s responsibility to do, for example by passing --system-header-prefix=<WebKit/ to the compiler.

[EWS Watchlist]

Comment on attachment 339492 [details]
Patch

Attachment 339492 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7559159

New failing tests:
svg/W3C-SVG-1.1/text-fonts-01-t.svg

[EWS Watchlist]

Created attachment 339507 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 339492 [details]
Patch

Attachment 339492 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7560535

New failing tests:
imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_menuitem-element.html

[EWS Watchlist]

Created attachment 339521 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 339492 [details]
Patch

Attachment 339492 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7561200

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 339523 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Timothy Hatcher]

Created attachment 339591 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 339591 [details]
Patch

Clearing flags on attachment: 339591

Committed r231383: <https://trac.webkit.org/changeset/231383>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.