WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
185277
[wpe] update the TestExpectations for encrypted-media after some fixes
https://bugs.webkit.org/show_bug.cgi?id=185277
Summary
[wpe] update the TestExpectations for encrypted-media after some fixes
Yacine Bandou
Reported
2018-05-03 16:30:45 PDT
Once the decryptor moved from AppendPipeline to Playbackpipeline and patches 185242 and 185244 will be fixed, WPT LayoutTests will no longer crash and some tests will pass.
Attachments
Patch
(9.01 KB, patch)
2018-05-03 19:06 PDT
,
Yacine Bandou
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews115 for mac-sierra
(3.16 MB, application/zip)
2018-05-04 02:05 PDT
,
EWS Watchlist
no flags
Details
Patch
(9.01 KB, patch)
2018-05-07 08:20 PDT
,
Yacine Bandou
no flags
Details
Formatted Diff
Diff
Patch
(9.01 KB, patch)
2018-05-09 03:23 PDT
,
Yacine Bandou
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Yacine Bandou
Comment 1
2018-05-03 19:06:40 PDT
Created
attachment 339504
[details]
Patch
EWS Watchlist
Comment 2
2018-05-04 02:05:26 PDT
Comment on
attachment 339504
[details]
Patch
Attachment 339504
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/7561756
New failing tests: imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests21.html
EWS Watchlist
Comment 3
2018-05-04 02:05:28 PDT
Created
attachment 339531
[details]
Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Xabier Rodríguez Calvar
Comment 4
2018-05-07 01:27:49 PDT
Comment on
attachment 339504
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=339504&action=review
> LayoutTests/platform/wpe/TestExpectations:983 > +
webkit.org/b/181225
media/encrypted-media/mock-MediaKeySystemAccess.html [ Crash ] > + > +[ Debug ] imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.https.html [ Crash ]
Why are these two tests crashing? I guess the other ones are timing out because they they go further without crashing, right?
Yacine Bandou
Comment 5
2018-05-07 01:57:22 PDT
(In reply to Xabier Rodríguez Calvar from
comment #4
)
> Comment on
attachment 339504
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=339504&action=review
> > > LayoutTests/platform/wpe/TestExpectations:983 > > +
webkit.org/b/181225
media/encrypted-media/mock-MediaKeySystemAccess.html [ Crash ] > > + > > +[ Debug ] imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.https.html [ Crash ] > > Why are these two tests crashing?
I did not investigate, its crashed before my pachese
> > I guess the other ones are timing out because they they go further without > crashing, right?
Yes, most tests are waiting for "waitingforkey" event
Xabier Rodríguez Calvar
Comment 6
2018-05-07 02:21:17 PDT
(In reply to Yacine Bandou from
comment #5
)
> > Why are these two tests crashing? > > I did not investigate, its crashed before my pachese > > Yes, most tests are waiting for "waitingforkey" event
Ok, we'll land after the dependencies then.
Yacine Bandou
Comment 7
2018-05-07 08:20:44 PDT
Created
attachment 339722
[details]
Patch
Yacine Bandou
Comment 8
2018-05-09 03:23:56 PDT
Created
attachment 339949
[details]
Patch
Xabier Rodríguez Calvar
Comment 9
2018-05-10 00:11:49 PDT
Comment on
attachment 339949
[details]
Patch Clearing flags on attachment: 339949 Committed
r231634
: <
https://trac.webkit.org/changeset/231634
>
Xabier Rodríguez Calvar
Comment 10
2018-05-10 00:11:53 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug