Bug 185270 - Make it easy to log compile times for all optimizing tiers
Summary: Make it easy to log compile times for all optimizing tiers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-03 14:48 PDT by Filip Pizlo
Modified: 2018-05-03 17:43 PDT (History)
6 users (show)

See Also:

Attachments
the patch (25.13 KB, patch)
2018-05-03 14:52 PDT, Filip Pizlo 		keith_miller: review+
Details | Formatted Diff | Diff
patch for landing, I think (25.39 KB, patch)
2018-05-03 16:08 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-05-03 14:48:37 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2018-05-03 14:52:40 PDT 
Created attachment 339471 [details]
the patch
Comment 2 EWS Watchlist 2018-05-03 14:54:12 PDT 
Attachment 339471 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/CompilerTimingScope.cpp:58:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keith Miller 2018-05-03 15:00:11 PDT 
Comment on attachment 339471 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339471&action=review

r=me.

> Source/JavaScriptCore/Sources.txt:710
> +runtime/CompilerTimingScope.cpp

This is kinda unrelated but I kinda feel like we should have a utilities directory or something. CompilerTimingScope doesn't feel very runtimey.
Comment 4 Mark Lam 2018-05-03 15:12:22 PDT 
Comment on attachment 339471 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339471&action=review

>> Source/JavaScriptCore/Sources.txt:710
>> +runtime/CompilerTimingScope.cpp
> 
> This is kinda unrelated but I kinda feel like we should have a utilities directory or something. CompilerTimingScope doesn't feel very runtimey.

Use the tools directory.
Comment 5 Filip Pizlo 2018-05-03 16:05:08 PDT 
(In reply to Mark Lam from comment #4)
> Comment on attachment 339471 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339471&action=review
> 
> >> Source/JavaScriptCore/Sources.txt:710
> >> +runtime/CompilerTimingScope.cpp
> > 
> > This is kinda unrelated but I kinda feel like we should have a utilities directory or something. CompilerTimingScope doesn't feel very runtimey.
> 
> Use the tools directory.

Will do!
Comment 6 Filip Pizlo 2018-05-03 16:08:00 PDT 
Created attachment 339481 [details]
patch for landing, I think

Moved the new files to tools/
Comment 7 EWS Watchlist 2018-05-03 16:10:59 PDT 
Attachment 339481 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/tools/CompilerTimingScope.cpp:58:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Filip Pizlo 2018-05-03 17:42:14 PDT 
Landed in https://trac.webkit.org/changeset/231338/webkit
Comment 9 Radar WebKit Bug Importer 2018-05-03 17:43:19 PDT 
<rdar://problem/39961963>