RESOLVED FIXED 185270
Make it easy to log compile times for all optimizing tiers 
https://bugs.webkit.org/show_bug.cgi?id=185270
Summary Make it easy to log compile times for all optimizing tiers
Filip Pizlo
Reported 2018-05-03 14:48:37 PDT
Patch forthcoming.
Attachments
the patch (25.13 KB, patch)
2018-05-03 14:52 PDT, Filip Pizlo 		keith_miller: review+
DetailsFormatted DiffDiff
patch for landing, I think (25.39 KB, patch)
2018-05-03 16:08 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2018-05-03 14:52:40 PDT
Created attachment 339471 [details] the patch
EWS Watchlist
Comment 2 2018-05-03 14:54:12 PDT
Attachment 339471 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/CompilerTimingScope.cpp:58: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 3 2018-05-03 15:00:11 PDT
Comment on attachment 339471 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=339471&action=review r=me. > Source/JavaScriptCore/Sources.txt:710 > +runtime/CompilerTimingScope.cpp This is kinda unrelated but I kinda feel like we should have a utilities directory or something. CompilerTimingScope doesn't feel very runtimey.
Mark Lam
Comment 4 2018-05-03 15:12:22 PDT
Comment on attachment 339471 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=339471&action=review >> Source/JavaScriptCore/Sources.txt:710 >> +runtime/CompilerTimingScope.cpp > > This is kinda unrelated but I kinda feel like we should have a utilities directory or something. CompilerTimingScope doesn't feel very runtimey. Use the tools directory.
Filip Pizlo
Comment 5 2018-05-03 16:05:08 PDT
(In reply to Mark Lam from comment #4) > Comment on attachment 339471 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339471&action=review > > >> Source/JavaScriptCore/Sources.txt:710 > >> +runtime/CompilerTimingScope.cpp > > > > This is kinda unrelated but I kinda feel like we should have a utilities directory or something. CompilerTimingScope doesn't feel very runtimey. > > Use the tools directory. Will do!
Filip Pizlo
Comment 6 2018-05-03 16:08:00 PDT
Created attachment 339481 [details] patch for landing, I think Moved the new files to tools/
EWS Watchlist
Comment 7 2018-05-03 16:10:59 PDT
Attachment 339481 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/tools/CompilerTimingScope.cpp:58: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 8 2018-05-03 17:42:14 PDT
Landed in https://trac.webkit.org/changeset/231338/webkit
Radar WebKit Bug Importer
Comment 9 2018-05-03 17:43:19 PDT
<rdar://problem/39961963>
Note You need to log in before you can comment on or make changes to this bug.