Range bisector should check the commits for repositories without change in specified range.
Created attachment 339472 [details] Patch
rdar://problem/39916741
Comment on attachment 339472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339472&action=review > Websites/perf.webkit.org/ChangeLog:8 > + For the repositories those do not have change in specified range, we still need to use them This is kind of wordy. How about "For repositories without a change in the specified range, > Websites/perf.webkit.org/ChangeLog:9 > + to filter commit sets. You need to explain why we need to do that. In a way, what you've stated so far is "what". We need "why". > Websites/perf.webkit.org/public/v3/commit-set-range-bisector.js:19 > + const topLevelRepositoriesWithCommitHasOrdering = firstCommitSet.topLevelRepositories() This phrase isn't grammatically correct. topLevelRepositoriesWithOrderedCommits? > Websites/perf.webkit.org/unit-tests/commit-set-range-bisector-tests.js:666 > + it('should use still check the repository revision even the repository has no change in the range', async () => { should still check or should still use? Can't have two verbs.
Created attachment 339488 [details] Patch
Comment on attachment 339488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339488&action=review > Websites/perf.webkit.org/ChangeLog:16 > + (async): Remove this? > Websites/perf.webkit.org/public/v3/commit-set-range-bisector.js:35 > + let commits = null; > + if (startCommit !== endCommit) > + commits = await CommitLog.fetchBetweenRevisions(repository, startCommit.revision(), endCommit.revision()); > + else > + commits = [startCommit]; How about just this? cont commits = startCommit == endCommit ? [startCommit] : await CommitLog.fetchBetweenRevisions(repository, startCommit.revision(), endCommit.revision());