Bug 185267 - PeerConnection should have its connectionState closed even if doing gathering
Summary: PeerConnection should have its connectionState closed even if doing gathering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-03 14:34 PDT by youenn fablet
Modified: 2018-05-04 16:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.34 KB, patch)
2018-05-03 14:43 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-sierra (3.28 MB, application/zip)
2018-05-04 00:42 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-05-03 14:34:27 PDT 
PeerConnection should have its connectionState closed even if doing gathering
Comment 1 youenn fablet 2018-05-03 14:43:20 PDT 
Created attachment 339469 [details]
Patch
Comment 2 EWS Watchlist 2018-05-04 00:42:04 PDT 
Comment on attachment 339469 [details]
Patch

Attachment 339469 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7561336

New failing tests:
imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_menuitem-element.html
Comment 3 EWS Watchlist 2018-05-04 00:42:05 PDT 
Created attachment 339525 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 WebKit Commit Bot 2018-05-04 08:18:40 PDT 
Comment on attachment 339469 [details]
Patch

Clearing flags on attachment: 339469

Committed r231352: <https://trac.webkit.org/changeset/231352>
Comment 5 WebKit Commit Bot 2018-05-04 08:18:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-05-04 08:19:24 PDT 
<rdar://problem/39976629>
Comment 7 Ryan Haddad 2018-05-04 14:31:58 PDT 
The test added with this change is a flaky timeout on iOS and macOS Release WK2 bots:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2FaddICECandidate-closed.html
Comment 8 youenn fablet 2018-05-04 16:54:49 PDT 
Thanks Ryan, I will fix the test.