RESOLVED FIXED185263
cleanup modules usage for the Test262-Runner 
https://bugs.webkit.org/show_bug.cgi?id=185263
Summary cleanup modules usage for the Test262-Runner
Leo Balter
Reported 2018-05-03 13:30:28 PDT
Fixup compatibilities for core modules usage in the Test262-Runner.
Attachments
Patch (2.17 KB, patch)
2018-05-03 13:31 PDT, Leo Balter 		no flags
DetailsFormatted DiffDiff
Patch (2.15 KB, patch)
2018-05-03 13:37 PDT, Leo Balter 		no flags
DetailsFormatted DiffDiff
Patch (2.64 KB, patch)
2018-05-03 13:51 PDT, Leo Balter 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2018-05-03 13:55 PDT, Leo Balter 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Leo Balter
Comment 1 2018-05-03 13:31:24 PDT
Created attachment 339450 [details] Patch
Michael Saboff
Comment 2 2018-05-03 13:36:18 PDT
Looks like this patch needs to be rebased.
Leo Balter
Comment 3 2018-05-03 13:37:03 PDT
Created attachment 339452 [details] Patch
Leo Balter
Comment 4 2018-05-03 13:37:23 PDT
Yes, I just rebased it. Thanks!
Leo Balter
Comment 5 2018-05-03 13:51:14 PDT
I just found another block bug in the process where the $configFile was being set after the CLI processing. It's being fixed in a follow up patch here.
Leo Balter
Comment 6 2018-05-03 13:51:32 PDT
Created attachment 339455 [details] Patch
Michael Saboff
Comment 7 2018-05-03 13:55:47 PDT
Comment on attachment 339455 [details] Patch r=me
Leo Balter
Comment 8 2018-05-03 13:55:56 PDT
Created attachment 339457 [details] Patch
Leo Balter
Comment 9 2018-05-03 13:58:32 PDT
we found the call processCLI is too fragile. so I moved it next to the main() call. Thanks for patience during the extra noise
Michael Saboff
Comment 10 2018-05-03 14:03:47 PDT
Comment on attachment 339457 [details] Patch r=me
WebKit Commit Bot
Comment 11 2018-05-03 14:28:03 PDT
Comment on attachment 339457 [details] Patch Clearing flags on attachment: 339457 Committed r231328: <https://trac.webkit.org/changeset/231328>
WebKit Commit Bot
Comment 12 2018-05-03 14:28:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2018-05-03 14:29:28 PDT
<rdar://problem/39954729>
Note You need to log in before you can comment on or make changes to this bug.