Bug 185263 - cleanup modules usage for the Test262-Runner
Summary: cleanup modules usage for the Test262-Runner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Balter
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-03 13:30 PDT by Leo Balter
Modified: 2018-05-03 14:29 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2018-05-03 13:31 PDT, Leo Balter 		no flags Details | Formatted Diff | Diff
Patch (2.15 KB, patch)
2018-05-03 13:37 PDT, Leo Balter 		no flags Details | Formatted Diff | Diff
Patch (2.64 KB, patch)
2018-05-03 13:51 PDT, Leo Balter 		no flags Details | Formatted Diff | Diff
Patch (2.76 KB, patch)
2018-05-03 13:55 PDT, Leo Balter 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Balter 2018-05-03 13:30:28 PDT 
Fixup compatibilities for core modules usage in the Test262-Runner.
Comment 1 Leo Balter 2018-05-03 13:31:24 PDT 
Created attachment 339450 [details]
Patch
Comment 2 Michael Saboff 2018-05-03 13:36:18 PDT 
Looks like this patch needs to be rebased.
Comment 3 Leo Balter 2018-05-03 13:37:03 PDT 
Created attachment 339452 [details]
Patch
Comment 4 Leo Balter 2018-05-03 13:37:23 PDT 
Yes, I just rebased it. Thanks!
Comment 5 Leo Balter 2018-05-03 13:51:14 PDT 
I just found another block bug in the process where the $configFile was being set after the CLI processing.

It's being fixed in a follow up patch here.
Comment 6 Leo Balter 2018-05-03 13:51:32 PDT 
Created attachment 339455 [details]
Patch
Comment 7 Michael Saboff 2018-05-03 13:55:47 PDT 
Comment on attachment 339455 [details]
Patch

r=me
Comment 8 Leo Balter 2018-05-03 13:55:56 PDT 
Created attachment 339457 [details]
Patch
Comment 9 Leo Balter 2018-05-03 13:58:32 PDT 
we found the call processCLI is too fragile. so I moved it next to the main() call.

Thanks for patience during the extra noise
Comment 10 Michael Saboff 2018-05-03 14:03:47 PDT 
Comment on attachment 339457 [details]
Patch

r=me
Comment 11 WebKit Commit Bot 2018-05-03 14:28:03 PDT 
Comment on attachment 339457 [details]
Patch

Clearing flags on attachment: 339457

Committed r231328: <https://trac.webkit.org/changeset/231328>
Comment 12 WebKit Commit Bot 2018-05-03 14:28:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2018-05-03 14:29:28 PDT 
<rdar://problem/39954729>