REGRESSION: Layout Test http/tests/security/location-cross-origin.html is a flaky failure

[Ryan Haddad]

The following layout test is flaky on debug bots.

http/tests/security/location-cross-origin.html

Probable cause:

Unknown.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Flocation-cross-origin.html

--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/security/location-cross-origin-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/security/location-cross-origin-actual.txt
@@ -49,7 +49,7 @@
 PASS Object.getOwnPropertyDescriptor(window.location, 'hash').set.call(frames[0].location, 1) threw exception SecurityError: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a cross-origin frame. Protocols, domains, and ports must match..
 PASS Object.defineProperty(frames[0].location, 'foo', { value: 1 }) threw exception SecurityError: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a cross-origin frame. Protocols, domains, and ports must match..
 PASS frames[0].location.href = 'about:blank' did not throw exception.
-PASS frames[0].location.href is "about:blank"
+FAIL frames[0].location.href should be about:blank. Threw exception SecurityError: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a cross-origin frame. Protocols, domains, and ports must match.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Ryan Haddad]

Flakiness dashboard suggests that this regressed with https://trac.webkit.org/changeset/230926, but I have not yet attempted to reproduce the failure locally.

[Chris Dumez]

(In reply to Ryan Haddad from comment #1)
> Flakiness dashboard suggests that this regressed with
> https://trac.webkit.org/changeset/230926, but I have not yet attempted to
> reproduce the failure locally.

Will look now.

[Chris Dumez]

(In reply to Chris Dumez from comment #2)
> (In reply to Ryan Haddad from comment #1)
> > Flakiness dashboard suggests that this regressed with
> > https://trac.webkit.org/changeset/230926, but I have not yet attempted to
> > reproduce the failure locally.
> 
> Will look now.

shouldNotThrow("frames[0].location.href = 'about:blank'");
    setTimeout(function() {
        shouldBeEqualToString("frames[0].location.href", "about:blank");
        finishJSTest();
    }, 100);

setTimeout 100, great.

[Chris Dumez]

Created attachment 339425 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 339425 [details]
Patch

Clearing flags on attachment: 339425

Committed r231315: <https://trac.webkit.org/changeset/231315>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39947471>