Bug 185254 - [GTK] Several tests are failing due to unexpected console logs
Summary: [GTK] Several tests are failing due to unexpected console logs
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-03 08:34 PDT by Miguel Gomez
Modified: 2018-05-31 02:51 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-05-03 08:34:16 PDT
There are several tests that are working fine, but are failing because of some console messages that are being added to the output that are not expected. Not all of them started failing at the same time, and some can't just be rebaselined as they seem to output different urls in the errors each time.

I think this could be related to https://trac.webkit.org/changeset/231000/webkit plus other changes after that.


These tests are failing since r231107:
http/tests/cache/disk-cache/redirect-chain-limits.html [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/http/tests/cache/disk-cache/redirect-chain-limits-pretty-diff.html
http/tests/xmlhttprequest/onloadend-event-after-error.html [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/http/tests/xmlhttprequest/onloadend-event-after-error-pretty-diff.html
http/tests/xmlhttprequest/response-access-on-error.html [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/http/tests/xmlhttprequest/response-access-on-error-pretty-diff.html
http/tests/xmlhttprequest/state-after-network-error.html [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/http/tests/xmlhttprequest/state-after-network-error-pretty-diff.html
imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-infinite.htm [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-infinite-pretty-diff.html
imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-network-error.htm [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-network-error-pretty-diff.html

These ones fail since r230857
http/tests/xmlhttprequest/XMLHttpRequestException.html [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/http/tests/xmlhttprequest/XMLHttpRequestException-pretty-diff.html
http/tests/xmlhttprequest/onloadend-event-after-sync-requests.html [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/http/tests/xmlhttprequest/onloadend-event-after-sync-requests-pretty-diff.html
imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-infinite-sync.htm [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-infinite-sync-pretty-diff.html
imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-network-error-sync.htm [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-network-error-sync-pretty-diff.html

And this one fails since r231040
http/tests/cache/network-error-during-revalidation.html [ Failure ]
diff -> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r231300%20(6521)/http/tests/cache/network-error-during-revalidation-pretty-diff.html
Comment 1 youenn fablet 2018-05-03 08:53:15 PDT
For MacOs and iOS ports, the network layer fails after 16 redirections currently.
It thus does not hit the 20 redirections error.
This might explain the difference here with libsoup.
See https://github.com/whatwg/fetch/issues/576 also.

One possibility might be for soup to align to 16 redirections.
As a near term solution, the only solution seems to use DumpJSConsoleLogInStdErr in GTK TestExpectations so that these lines do not appear.
Comment 2 Miguel Gomez 2018-05-31 02:51:55 PDT
Another test that fails due to console messages

http/tests/xmlhttprequest/connection-error-sync.html [ Failure ]

and diff is

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/xmlhttprequest/connection-error-sync-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/xmlhttprequest/connection-error-sync-actual.txt
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 22: Load cannot follow more than 20 redirections
+CONSOLE MESSAGE: line 22: XMLHttpRequest cannot load http://127.0.0.1:8000/xmlhttprequest/resources/infinite-loop.php due to access control checks.
 Test the behavior of a sync XMLHttpRequest that encounters an infinite redirection loop.
 
 Exception NetworkError; code=19; number=undefined (0); message=' A network error occurred.'