Bug 185241 - REGRESSION (r231014): Entitlements are not applied to XPC services on macOS
Summary: REGRESSION (r231014): Entitlements are not applied to XPC services on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
: 185429 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-05-03 01:00 PDT by Tim Horton
Modified: 2018-05-08 10:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.67 KB, patch)
2018-05-03 01:01 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (3.69 KB, patch)
2018-05-03 01:02 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-05-03 01:00:54 PDT 
REGRESSION (r231014): Entitlements are not applied to XPC services on macOS
Comment 1 Tim Horton 2018-05-03 01:01:07 PDT 
Created attachment 339397 [details]
Patch
Comment 2 Tim Horton 2018-05-03 01:02:09 PDT 
Created attachment 339398 [details]
Patch
Comment 3 WebKit Commit Bot 2018-05-03 01:50:15 PDT 
Comment on attachment 339398 [details]
Patch

Clearing flags on attachment: 339398

Committed r231299: <https://trac.webkit.org/changeset/231299>
Comment 4 WebKit Commit Bot 2018-05-03 01:50:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-05-03 01:51:30 PDT 
<rdar://problem/39935564>
Comment 6 mitz 2018-05-08 10:11:19 PDT 
(In reply to WebKit Commit Bot from comment #3)
> Comment on attachment 339398 [details]
> Patch
> 
> Clearing flags on attachment: 339398
> 
> Committed r231299: <https://trac.webkit.org/changeset/231299>

After this change, the Development service isn’t getting signed with entitlements when building for macOS.
Comment 7 mitz 2018-05-08 10:13:12 PDT 
(In reply to mitz from comment #6)
> (In reply to WebKit Commit Bot from comment #3)
> > Comment on attachment 339398 [details]
> > Patch
> > 
> > Clearing flags on attachment: 339398
> > 
> > Committed r231299: <https://trac.webkit.org/changeset/231299>
> 
> After this change, the Development service isn’t getting signed with
> entitlements when building for macOS.

The be fair, maybe that was also a problem before this change and after r231014, but in any case, this change didn’t fix the Development service.
Comment 8 mitz 2018-05-08 10:25:45 PDT 
Filed bug 185429.
Comment 9 mitz 2018-05-08 10:29:02 PDT 
*** Bug 185429 has been marked as a duplicate of this bug. ***
Comment 10 mitz 2018-05-08 10:29:23 PDT 
I was very confused and this bug fixed what I thought it had broken.