Bug 185236 - Re-enable Network Extension support in the WebContent process
Summary: Re-enable Network Extension support in the WebContent process
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on:
Reported: 2018-05-02 21:56 PDT by Brent Fulgham
Modified: 2018-05-06 16:35 PDT (History)
5 users (show)

See Also:

Patch (2.24 KB, patch)
2018-05-02 21:58 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-05-02 21:56:39 PDT
In Bug 183192 I removed general network API access. Unfortunately, the stock "(allow-network-common)" also enabled Network Extension access.

Amusingly, Network Extension is really more about understanding URLs than it is about networking per-se, so it should not have been removed since it is used by our content filtering logic.

This path adds access to the Network Extension features back to the WebContent process so our content filtering features work properly.
Comment 1 Brent Fulgham 2018-05-02 21:57:23 PDT
Comment 2 Brent Fulgham 2018-05-02 21:58:09 PDT
Created attachment 339387 [details]
Comment 3 WebKit Commit Bot 2018-05-03 06:46:12 PDT
Comment on attachment 339387 [details]

Clearing flags on attachment: 339387

Committed r231302: <https://trac.webkit.org/changeset/231302>
Comment 4 WebKit Commit Bot 2018-05-03 06:46:14 PDT
All reviewed patches have been landed.  Closing bug.